Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better GNOME aesthetic integration #72

Open
ghost opened this issue Dec 5, 2022 · 4 comments
Open

Better GNOME aesthetic integration #72

ghost opened this issue Dec 5, 2022 · 4 comments

Comments

@ghost
Copy link

ghost commented Dec 5, 2022

In some screens, using Adwaita-dark, it's hard to tell what's going on due to dark text on dark backgrounds. If we could modify the text colours, and set the icon packs to use (such as changing it to Breeze Dark on GNOME) that would be great.

image
image
bernds added a commit that referenced this issue Dec 5, 2022
@bernds
Attempt to fix colors for dark theme
df38124 
This should hopefully help with issue #72. There were two areas in the
board window with a palette set, for no clear reason, and a hardcoded
black color as the default for server messages.
@bernds
Copy link
Owner

bernds commented Dec 5, 2022

Please let me know if the last commit helps.

@ghost
Copy link
Author

ghost commented Dec 8, 2022 •
edited by ghost
Loading

Please let me know if the last commit helps.

It certainly helped for the board screen, but the online screen still has the same issues (see bottom right).

image
image

Also, I know this might take some more time and effort, but it would be nice to be able to choose the icon theme from within the program. On GNOME, Qt apps might not integrate its icons but most major ones like Scribus or Kdenlive let you choose the icon theme directly to use icons they were designed for, like KDE Breeze's.

Thank you, though! 🙏

@bernds
Copy link
Owner

bernds commented Dec 8, 2022

Hmm, the server text is very odd. I'll keep poking at it, but I have no real idea.

Also don't know what to do about icon themes. It might be possible to get some icons from the system, but the majority (stones and such) are specific to q5go and not part of any system theme. Also, the Qt icon system is very confusing :)

@ghost
Copy link
Author

ghost commented Dec 9, 2022

Hmm, the server text is very odd. I'll keep poking at it, but I have no real idea.

Also don't know what to do about icon themes. It might be possible to get some icons from the system, but the majority (stones and such) are specific to q5go and not part of any system theme. Also, the Qt icon system is very confusing :)

No worries! The icons as they are now look pretty good! Thanks for the effort regardless 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bernds