-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include arch label #934
include arch label #934
Conversation
Just curious, grepping the architecture from |
Afaik, this is for a template ( |
One more question then - does this label appear on the nodes? (If so, we'll need to figure out how to set it for the on-prem nodes.) |
Just to clarify/reiterate from the daily meeting. The label However, as Cluster Autoscaler needs the template of the node, to simulate scheduling, we need to populate this label without creating a new node. Imagine the case where you have some pending pods, with the node selector set to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
closes #665
The API for retrieving the architecture isn't uniform across all cloud SDKs,
For GCP, Azure The architecture is retrieved via the Image client and then the Architecture is set to all the cached types. For OCI a regex match is done for the ARM machine type, but since the ARM type on OCI is a Flex instance, which claudie doesn't surpport, I couldn't test it