Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/backup claduie #958

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Feat/backup claduie #958

merged 4 commits into from
Jul 18, 2023

Conversation

Despire
Copy link
Contributor

@Despire Despire commented Jul 18, 2023

closes #897

MarioUhrik
MarioUhrik approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@MarioUhrik MarioUhrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work Matus

For my curiosity, why the kustomization.yaml changes?

@Despire
Copy link
Contributor Author

Despire commented Jul 18, 2023 •
edited
Loading

why the kustomization.yaml changes?

Otherwise the secrets or config maps wouldn't be backed up and when restoring it would fail

Everything thats part of claudie should have the label so the backup will be complete

@MarioUhrik
Copy link
Contributor

why the kustomization.yaml changes?

Otherwise the secrets or config maps wouldn't be backed up and when restoring it would fail

Everything thats part of claudie should have the label so the backup will be complete

Perfect, thanks.

My point is, if the labels are missing from somewhere, we should add them to the manifests.
But yes, for configmaps and secrets, the only way to have those labels is via kustomize options, so your solution seems optimal

@Despire Despire added this pull request to the merge queue Jul 18, 2023
Merged via the queue into master with commit 795a0ea Jul 18, 2023
@Despire Despire deleted the feat/backup-claduie branch July 18, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernardhalas bernardhalas bernardhalas left review comments

@MarioUhrik MarioUhrik MarioUhrik approved these changes

@cloudziu cloudziu Awaiting requested review from cloudziu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Claudie backup/restore
3 participants
@Despire @MarioUhrik @bernardhalas