[RORDEV-1257] refactoring #11
Conversation
| matrix: | ||
| version: [8x, 7x] | ||
| version: ["8.15.2", "7.17.24"] |
There was a problem hiding this comment.
What is the flow after the new version release for Kibana 7.x or 8.x? Should we upgrade it manually?
| const actual = result.saved_objects.some( | ||
| saved_object => saved_object.id === 'my-pattern' || saved_object.id === 'my-dashboard' | ||
| ); | ||
| // eslint-disable-next-line no-unused-expressions |
There was a problem hiding this comment.
looks like this es lint disable is redundant
| kbnApiAdvancedClient.getDataViews(userCredentials, 'infosec_group').then(result => { | ||
| const actual = result.data_view.some(saved_object => saved_object.id === 'logstash'); | ||
|
|
||
| // eslint-disable-next-line no-unused-expressions |
There was a problem hiding this comment.
looks like this es lint disable is redundant
| import { Settings } from '../support/page-objects/Settings'; | ||
|
|
||
| describe('Reporting index', () => { | ||
| describe.skip('Reporting index', () => { |
There was a problem hiding this comment.
Is it intentionally skipped?
| }); | ||
|
|
||
| try { | ||
| const response: Response = await fetch(url, { |
There was a problem hiding this comment.
In the JS world, you can shorthand it to
{
method,
headers,
body,
agent
}
| headers: headers, | ||
| body: body, | ||
| agent | ||
| } as RequestInit); |
There was a problem hiding this comment.
IMO as in this case type assertion is redundant here, in a ts it's a last resort when you say typescript compiler to ignore inferred and analyzed type because you know better, for example I can make a typo, in a property key, but it will be valid in case of type assertion
but when you let typescript infer it, it's protected
| @@ -0,0 +1,112 @@ | |||
| import { Agent } from 'https'; | |||
| import fetch, { RequestInit, Response } from 'node-fetch'; | |||
There was a problem hiding this comment.
Seems like there are missing types here, you can add them via yarn add --dev @types/node-fetch
| esDelete({ endpoint, credentials }: { endpoint: string, credentials: string }): Chainable<Subject>; | ||
| } | ||
|
|
||
| export type Payload = string | object |
Changes:
node-fetchclient instead ofcurlin Cypress-KBN/ES API interaction methods