-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RORDEV-1257] ECK+ROR tested using E2E tests #12
base: feature/RORDEV-1257_refactoring
Are you sure you want to change the base?
[RORDEV-1257] ECK+ROR tested using E2E tests #12
Conversation
coutoPL
commented
Oct 5, 2024
•
edited
Loading
edited
- new environment: ECK
wip wip wip kibana ssl wip wip wip wip cy-task-verification fix issues improvements wip ECK test in gh actions ECK test in gh actions fix ECK test in gh actions ECK test in gh actions ECK test in gh actions ECK test in gh actions ECK test in gh actions ECK test in gh actions ECK test in gh actions ECK test in gh actions ECK test in gh actions ECK test in gh actions ECK test in gh actions ECK test in gh actions ECK test in gh actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM I left few small non-blocking comments
@@ -0,0 +1,13 @@ | |||
# README | |||
|
|||
## Requirements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a minimum version for these required tools?
* kind tool installed (https://github.com/kubernetes-sigs/kind) | ||
|
||
## RUNNING | ||
1. Running the ECK+ROR PoC: `$ ./start.sh --es <ES_VESION> --kbn <KBN_VERSION>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it still PoC?
@@ -22,6 +22,9 @@ services: | |||
- bootstrap.memory_lock=true | |||
# for a sake of debugging and profiling | |||
- "ES_JAVA_OPTS=-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5000 -Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.port=9010 -Dcom.sun.management.jmxremote.local.only=false -Dcom.sun.management.jmxremote.authenticate=false -Dcom.sun.management.jmxremote.ssl=false -Dcom.sun.management.jmxremote.rmi.port=9010 -Djava.rmi.server.hostname=127.0.0.1" | |||
- KIBANA_SERVICE_ACCOUNT_TOKEN=UNUSED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must we pass these dummy ECK-based values?