Get full fullscreen in Firefox #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox steals away 1px of the screen to receive events in fullscreen. (See https://bugzilla.mozilla.org/show_bug.cgi?id=729011). Detect this scenario and calculate the scale values accordingly. Using the window.outerWidth/Height properties also works around the incremental resizing that occurs when Firefox transitions into fullscreen.
mojavelinux
force-pushed
the
full-fullscreen
branch
from
18bd8d5
to
3b56e8d
Compare
|
Note that |
|
It appears the root cause no longer exists as of Firefox 40. They seem to have changed the way that fullscreen works. I think the change is still worth doing, but it may be less of a priority now. |
|
Actually, never mind. It just seems that it only happens in some windows. In other windows I still get 1px less than the screen height. I'll keep digging to see if I can figure out the terms of the condition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox steals away 1px of the screen to receive events in fullscreen. (See https://bugzilla.mozilla.org/show_bug.cgi?id=729011). Detect this scenario and calculate the scale values accordingly.
Using the window.outerWidth/Height properties also works around the incremental resizing that occurs when Firefox transitions into fullscreen (due to its own transition on the chrome).