Move receiver and rssi configuration to receiver tab #2386
Conversation
There was a problem hiding this comment.
First of all thanks for all this PRs that make the Configurator easier and more intuitive.
Apart from the gulpfile that you have detected...
Only some comments about the css.
What I see is that it has A LOT of new styles. Are all of them needed for that? Usually the major part of styles must be in the common css, only some differences if needed must be here, but I see a long list of them.
But the CSS is mesh of updates that maybe we can never clean so maybe this is the simple way to move this :)
src/css/tabs/receiver.css
Outdated
| @@ -140,6 +140,36 @@ | |||
| background-color: #14407a; | |||
| } | |||
|
|
|||
| /* from configuration tab */ | |||
There was a problem hiding this comment.
Is better to remove the comment or change from something more "general" like "rx configuration". Any future user will not know nothing about what was in the configuration tab and what not and can confuse them.
src/css/tabs/receiver.css
Outdated
| line-height: 18px; | ||
| } | ||
|
|
||
| .tab-receiver .serialRXBox, .spiRxBox { |
There was a problem hiding this comment.
Maybe this must be:
| .tab-receiver .serialRXBox, .spiRxBox { | |
| .tab-receiver .serialRXBox, .tab-receiver .spiRxBox { |
src/css/tabs/receiver.css
Outdated
| @@ -559,6 +589,10 @@ | |||
| margin-bottom: 10px; | |||
| } | |||
|
|
|||
| select.features.rxMode, select.serialRX { | |||
There was a problem hiding this comment.
This does not need the .tab-receiver to maintain consistence with the other styles? If it is a general feature style, maybe is better to go in a common css file. Is this if only for this tab, is better to add the .tab-receiver to go with the others styles.
| select.features.rxMode, select.serialRX { | |
| .tab-receiver select.features.rxMode, .tab-receiver select.serialRX { |
src/css/tabs/receiver.css
Outdated
| .tab-receiver .gps td:nth-child(2) { | ||
| width: auto; | ||
| } | ||
| select.features.rxMode, select.serialRX, .dshotbeacon > td > div.select > div, .dshotbeacon select.dshotBeeperBeaconTone { |
There was a problem hiding this comment.
The same than before about adding the .tab-receiver to the style.
haslinghuis
force-pushed
the
fix_81
branch
3 times, most recently
from
17849c4
to
499671a
Compare
|
Fixed previous issues with another iteration (starting over, going backwards, hacking configuration to a minimum to see what's happening and really needed) Have added a class |
haslinghuis
force-pushed
the
fix_81
branch
2 times, most recently
from
256f822
to
74f3f5b
Compare
|
Okay. Because configuration does |
haslinghuis
force-pushed
the
fix_81
branch
2 times, most recently
from
dbfb0c4
to
a9ce411
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Is this out of draft? Sometimes we don't review the code because we are waiting until some kind of "final form" is ready... |
|
It's ready but it needs clean up , but I don't want conflict with #2356 |
haslinghuis
force-pushed
the
fix_81
branch
3 times, most recently
from
cb529dc
to
cae65ce
Compare
|
Dark mode fix included 🕶️ |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Looks good now. Potentially one future improvement would be to move both ADC and RC channel based RSSI into the same panel, and only allow one to be selected at any time:
|
Fixes: #81