vtx_osd_variant_fix #2964
Merged
vtx_osd_variant_fix #2964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haslinghuis
reviewed
Jun 28, 2022
haslinghuis
requested changes
Jun 28, 2022
|
i know this is messed up again, i'm having a heck of a time with squashing commits |
haslinghuis
previously approved these changes
Jun 28, 2022
|
@P-I-Engineer please check https://github.com/betaflight/betaflight/wiki/Betaflight-Contribution. You need to master this. |
|
i keep getting merge commits and not sure where they're coming from |
P-I-Engineer
force-pushed
the
vtx_osd_variant_gitfix
branch
2 times, most recently
from
f73c3b1
to
2670f64
Compare
haslinghuis comment inc comments inc haslinghuis comment inc Revert "haslinghuis comment inc" This reverts commit cbe38ff. Update src/js/tabs/osd.js Co-authored-by: haslinghuis <[email protected]> Update src/js/tabs/osd.js Co-authored-by: haslinghuis <[email protected]> clean clean fix clean
P-I-Engineer
force-pushed
the
vtx_osd_variant_gitfix
branch
from
39b64b6
to
e17cf1a
Compare
|
got it |
|
Kudos, SonarCloud Quality Gate passed!
|
haslinghuis
approved these changes
Jun 29, 2022
|
AUTOMERGE: (FAIL)
|
McGiverGim
approved these changes
Jun 30, 2022
|
Do you want to test this code? Here you have an automated build: |
blckmn
approved these changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a PR to replace #2755 i had too many github issues to salvage
I've created an osd variant for VTX channel that displays only the VTXpower.
pull request is partial approved in betaflight here
betaflight/betaflight#11275