-
-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise upper limit of dyn_idle_min_rpm #2985
Conversation
This comment has been minimized.
This comment has been minimized.
The original idea is from @sugaarK, I just made the PR for it. |
AUTOMERGE: (FAIL)
|
Works good too! |
src/tabs/pid_tuning.html
Outdated
@@ -762,7 +762,7 @@ | |||
</tr> | |||
|
|||
<tr class="idleMinRpm"> | |||
<td><input type="number" name="idleMinRpm-number" step="1" min="0" max="100"/></td> | |||
<td><input type="number" name="idleMinRpm-number" step="1" min="0" max="200"/></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not depend of the Betaflight version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Updated. As the PG version in firmware has not been raised we should keep it designate this for 4.4 anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case the CLI command dyn_idle_min_rpm
is backwards compatible cause we're only extending the range, not the underlying data type. So we could add betaflight/betaflight#11769 to 4.3.2.
The configurator part still needs to go into 4.4 release (I guess? Or do we have sub-versions for BFC?). But for the 4.3.2 firmware you would at least have access to the greater dyn idle range via CLI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Changed to 4.3
This comment has been minimized.
This comment has been minimized.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This comment has been minimized.
This comment has been minimized.
src/js/tabs/pid_tuning.js
Outdated
@@ -492,6 +492,10 @@ pid_tuning.initialize = function (callback) { | |||
$('.rpmFilter').hide(); | |||
} | |||
|
|||
if (semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_44)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be 1.45??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firmware PR is tagged as 4.3.2 not 4.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so, we need to fix it first, it is taged after merge and is merged on ly in master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
d4b5add
to
681b326
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Update after betaflight/betaflight/pull/11769
Thanks to @KarateBrot for raising the idea.