Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed board selection not sticking #3068

Merged
merged 3 commits into from
Nov 6, 2022
Merged

Fixed board selection not sticking #3068

merged 3 commits into from
Nov 6, 2022

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Nov 5, 2022

What it says on the tin. The board selection was not sticking.

@blckmn blckmn self-assigned this Nov 5, 2022
@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis added this to the 10.9.0 milestone Nov 5, 2022
haslinghuis
haslinghuis previously requested changes Nov 5, 2022
View reviewed changes
Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not expose the cloud build options anymore.

@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member Author

blckmn commented Nov 5, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@blckmn
Copy link
Member Author

blckmn commented Nov 5, 2022

This does not expose the cloud build options anymore.

There was a small bug where call trigger change didn't actually work if it didn't change. Fixed by calling directly.

@blckmn blckmn dismissed haslinghuis’s stale review November 5, 2022 10:49

This should be sorted now

@sonarcloud
Copy link

sonarcloud bot commented Nov 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2022

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn blckmn merged commit e9bd426 into betaflight:master Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@blckmn blckmn

Labels
BUG Cleanup Tested
Projects
None yet
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@blckmn @haslinghuis