Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix virtual OSD elements and OSD backwards compability bug #3118

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Fix virtual OSD elements and OSD backwards compability bug #3118

merged 1 commit into from
Dec 6, 2022

Conversation

haslinghuis
Copy link
Member

Fixes: #3114

Also fixes backwards compatibility in OSD.

@haslinghuis haslinghuis added this to the 10.9.0 milestone Dec 6, 2022
@haslinghuis haslinghuis self-assigned this Dec 6, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@blckmn
Copy link
Member

blckmn commented Dec 6, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

McGiverGim
McGiverGim approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@haslinghuis haslinghuis merged commit 212b0bd into betaflight:master Dec 6, 2022
@haslinghuis haslinghuis deleted the fix-osd-virtual branch December 6, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@sugaarK sugaarK sugaarK approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: BUGFIX
Projects
None yet
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.

Update the virtual FC data
4 participants
@haslinghuis @blckmn @McGiverGim @sugaarK