Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use esm modules for session storage #3191

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Use esm modules for session storage #3191

merged 1 commit into from
Jan 4, 2023

Conversation

chmelevskij
Copy link
Member

  • use esm for session storage
  • refactor release checker and loader to modules

@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis added this to the 10.9.0 milestone Dec 31, 2022
@mergify mergify bot mentioned this pull request Dec 31, 2022
Merged
@github-actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Dec 31, 2022 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@chmelevskij
Use esm modules for session storage
2261bae 
* use esm for session storage
* refactor release checker and loader to modules
@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit df25ec7 into betaflight:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckmn blckmn blckmn approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

Assignees

@chmelevskij chmelevskij

Labels
Rebase Required RN: REFACTOR
Projects
None yet
Milestone
10.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chmelevskij @blckmn @haslinghuis