Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor. Core build mode. #3236

Merged
merged 5 commits into from
Jan 14, 2023
Merged

Refactor. Core build mode. #3236

merged 5 commits into from
Jan 14, 2023

Conversation

blckmn
Copy link
Member

@blckmn blckmn commented Jan 12, 2023

No description provided.

@github-actions

This comment has been minimized.

@McGiverGim
Copy link
Member

Are this rename necessary at this stage? Again, it produces that all the translators need to translate it again.

@github-actions

This comment has been minimized.

@blckmn
Copy link
Member Author

blckmn commented Jan 13, 2023

Are this rename necessary at this stage? Again, it produces that all the translators need to translate it again.

It's only renamed in english, the existing translations can remain - and if they get updated great, if not there is no harm done as "classic" is still a valid description.

@github-actions

This comment has been minimized.

@blckmn
Copy link
Member Author

blckmn commented Jan 13, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis added this to the 10.9.0 milestone Jan 13, 2023
@McGiverGim
Copy link
Member

Are this rename necessary at this stage? Again, it produces that all the translators need to translate it again.

It's only renamed in english, the existing translations can remain - and if they get updated great, if not there is no harm done as "classic" is still a valid description.

That does not work in this way. When you change the English translation, at Crowdin, all the translations are invalidated. Your work here modifying all the languages does not serve for nothing because it will be replaced with Crowdin files the next update.

@haslinghuis haslinghuis merged commit ce2b698 into betaflight:master Jan 14, 2023
@blckmn blckmn deleted the core_mode branch January 28, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants