Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit groundspeed in UI to 3m/s #3362

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

haslinghuis
Copy link
Member

Requested by @ctzsnooze

Limit's groundspeed to 3.0 m/s instead of 0.3 m/s
CLI can override this range. As long user does not alter the setting in UI the CLI range is used otherwise the UI range comes into effect.

@haslinghuis haslinghuis added this to the 10.10.0 milestone Feb 27, 2023
@haslinghuis haslinghuis self-assigned this Feb 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@ctzsnooze
Copy link
Member

Thanks, @haslinghuis, this will keep the ordinary user's groundspeed above the minimum necessary for correct IMU heading calculations.
An advanced user can use the CLI to set a lower value, including zero, for specialised testing purposes.
3.0m/s is probably the minimum safe value for a reliable GPS Rescue.

@blckmn
Copy link
Member

blckmn commented Feb 27, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis merged commit 7f3ba27 into betaflight:master Feb 27, 2023
@haslinghuis haslinghuis deleted the limit-groundspeed branch February 27, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

3 participants