Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUX modes updated in help tips and virtuelFC, also sort of LinkedTo option list at Mode tab #3519

Merged
merged 4 commits into from
Jul 29, 2023
Merged

AUX modes updated in help tips and virtuelFC, also sort of LinkedTo option list at Mode tab #3519

merged 4 commits into from
Jul 29, 2023

Conversation

HThuren
Copy link
Member

@HThuren HThuren commented Jul 19, 2023

Add all modes found in betaflight msp/msp_box.c
(And sort the list to find the missing elements)

@github-actions

This comment has been minimized.

Sign in to view
@haslinghuis haslinghuis added this to the 10.10.0 milestone Jul 19, 2023
@blckmn
Copy link
Member

blckmn commented Jul 19, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> FAIL
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@haslinghuis
Copy link
Member

Sorting the list is not as strait forward as in other tabs.

@HThuren
Copy link
Member Author

HThuren commented Jul 19, 2023

no, I working on sort of the modes list, but not that easy due to special treatment of ARM mode. But hopefully succed
The LinkedTo are sorted in my branch

@github-actions

This comment has been minimized.

Sign in to view
@HThuren
Copy link
Member Author

HThuren commented Jul 21, 2023

I believe this PR need no more development.
(Sort of modes will come in another PR, quite difficult not handle)

@HThuren HThuren changed the title Add missing aux modes to help AUX modes updated in help tips and virtuelFC, also sort of LinkedTo option list at Mode tab Jul 21, 2023
@github-actions

This comment has been minimized.

Sign in to view
@HThuren
Update VirtualFC.js
b7c17a2 
AIRMODE are "AIR MODE"
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@HThuren
Copy link
Member Author

HThuren commented Jul 21, 2023

Discovered AIRMODE are split in msp_box.c, ie. "AIR MODE"

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

nerdCopter
nerdCopter approved these changes Jul 29, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving untested; visual inspection only

@haslinghuis haslinghuis merged commit 1a4a3a5 into betaflight:master Jul 29, 2023
9 checks passed
@HThuren HThuren deleted the addMissingModeHelp branch July 30, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

Assignees

@HThuren HThuren

Labels
RN: UI Tested
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@HThuren @blckmn @haslinghuis @nerdCopter