Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPS waiting info margin #3525

Merged
merged 2 commits into from
Jul 23, 2023
Merged

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jul 22, 2023

Fixes: #3524

Added some colors in second commit:

image

@haslinghuis haslinghuis added this to the 10.10.0 milestone Jul 22, 2023
@haslinghuis haslinghuis self-assigned this Jul 22, 2023
@github-actions

This comment has been minimized.

@HThuren
Copy link
Member

HThuren commented Jul 22, 2023

Would have approved if I did have the ability ...

@blckmn
Copy link
Member

blckmn commented Jul 22, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit d1cb74e into betaflight:master Jul 23, 2023
9 checks passed
@haslinghuis haslinghuis deleted the fix-waiting branch July 23, 2023 17:12
@HThuren
Copy link
Member

HThuren commented Aug 1, 2023

@haslinghuis seems to have trouble when translated, the construction like used.startsWith('used') don't catch 'used' since it translated.
If you use used.startsWith(i18n.getMessage(gnssUsedUsed))

I cant change, if you want, same time I remove the double unit for latitude/longitude ?

example
image

@haslinghuis
Copy link
Member Author

Good catch. Yes can fix both at the same time.

@HThuren
Copy link
Member

HThuren commented Aug 1, 2023

Do you want 'locked' to be green as well, when Used are stated ?
image
like:
image

@haslinghuis
Copy link
Member Author

haslinghuis commented Aug 1, 2023

Would like to have orange for locked and yellow for searching :)

Otherwise only want fully locked, used and healthy to be green:
1st column: unusable, no signal, searching, locked and fully locked
2nd column: unused, used
3d column: non healthy, healthy

@HThuren
Copy link
Member

HThuren commented Sep 5, 2023

Would like to have orange for locked and yellow for searching :)

Otherwise only want fully locked, used and healthy to be green: 1st column: unusable, no signal, searching, locked and fully locked 2nd column: unused, used 3d column: non healthy, healthy

#3566 do the job :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

GPS waiting info in wrong position
5 participants