-
-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lost context #3824
Fix lost context #3824
Conversation
This comment has been minimized.
This comment has been minimized.
ca2967f
to
b6e36ac
Compare
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
Self - healing :) Removed the class usage of Model in |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
Already have tried to include |
b6e36ac
to
a4c29f7
Compare
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
a4c29f7
to
2813a54
Compare
This comment has been minimized.
This comment has been minimized.
Found that after nulling the renderer object it was still trying to rotate on it. Mitigated and testing now.
https://developer.mozilla.org/en-US/docs/Web/API/WEBGL_lose_context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't get any errors, and seems well done
|
2813a54
to
0f1dff7
Compare
This comment has been minimized.
This comment has been minimized.
Think adding event listeners to restore context would be over engineering here as switching tabs will restore context as overruns are halted now. https://threejs.org/docs/#api/en/renderers/WebGLRenderer |
|
No issues with HP Elite 840 Pro (Intel I5-4200U with16GB SODIMM and Samsung SSD 840 Pro 256GB) using MS Windows 10 Pro. |
Tested 90 minutes without issue. Only will remove the CSS change as the preview is too big for 1600x900 EDIT: Also rebased on master |
0f1dff7
to
ee7a567
Compare
ee7a567
to
847f6d4
Compare
Quality Gate passedIssues Measures |
Do you want to test this code? Here you have an automated build: |
Changes
renderer.setSize