Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the dark / light theme work with PWA #3883

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

McGiverGim
Copy link
Member

Changed the way the dark-theme is loaded. Thanks to @VitroidFPV for the suggestion.

Now the PWA is dark theme only, with this it respects the user preference (light, dark or auto).

The less file shows a lot of changes, but is because it contains one indentation more and it has gone crazy. If you compare ignoring spaces the changes are only this, nothing more:
image

I've done some tests, but any test more will be appreciated. It must work both, under PWA and under Node.

Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for origin-betaflight-configurator ready!

Name Link
🔨 Latest commit 1d66c58
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-configurator/deploys/6615875cc35c260008501693
😎 Deploy Preview https://deploy-preview-3883--origin-betaflight-configurator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This comment has been minimized.

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • tested as working both PWA and NWjs. only quick-tested, did not check every tab.

Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one issue using NWjs

PR:

image

Master:

image

@McGiverGim
Copy link
Member Author

I don't know why is not equal... the problem is that the CSS of pid_tuning.css overwrites the background...
I fixed it anyway:
image

It seems the spacer between tabs is white and not black too... I will look into it... I suppose similar problem.

This comment has been minimized.

Changed the way the dark-theme is loaded. Thanks to @vitroid for the suggestion.
@McGiverGim
Copy link
Member Author

@haslinghuis I think I've fixed it now :)

Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.8% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Linux
Betaflight-Configurator-Android
Betaflight-Configurator-Windows
Betaflight-Configurator-macOS
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@haslinghuis haslinghuis merged commit be0103f into betaflight:master Apr 9, 2024
12 checks passed
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
Changed the way the dark-theme is loaded. Thanks to @vitroid for the suggestion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

4 participants