-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug 8 columns #12445
Debug 8 columns #12445
Conversation
-added 4 additional columns to debug -modified dshot.c to allow rpm telemetry to log erpm for up to 8 motors
This comment has been minimized.
This comment has been minimized.
AUTOMERGE: (FAIL)
|
If would be great if we could use this either for a single debug mode with eight channels or two of the existing modes. Perhaps have a |
@SteveCEvans yea, I like that. I think a case could be made for both, but it would require a lot more extensive changes to have 2 separate debugs, which would also require changes to the configurator BB logging tab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sure we don't write to nonexistent debug channels in case DEBUG16_VALUE_COUNT
is smaller than the number of max supported motors. Right now it's both set to 8 and in theory this works perfectly. But if someone changes the number of debug channels to 7 for example and flies with 8 motors, the FC would freeze and we wouldn't know where the bug comes from (not without debugging).
Co-authored-by: Jan Post <[email protected]>
@KarateBrot good catch, thanks |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@bw1129 you forgot to fix line 236 :) |
Co-authored-by: Jan Post <[email protected]>
@haslinghuis oops, thanks, done! |
Do you want to test this code? Here you have an automated build: |
This PR adds an additional 4 columns to the blackbox debug variable for a total of 8 useable columns of data (see associated Blackbox Explorer PR betaflight/blackbox-log-viewer#631). This is extremely useful for logging such things as RPM across all 8 motors of an x8 cinelifter for example, which is very useful for troubleshooting a potentially unhealthy motor or ESC before bad things happen (see attached screenshot). There are many other instances where > 4 columns of debug data would be very useful (Eg, to track the movement of all 5 DNs, etc). The PR involves minor changes to blackbox.c and debug.h. The PR also includes a small change to dshot.c to allow logging of erpm data for up to 8 motors.