Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Évite l'affichage d'un message de déprécation causé par Devise #1233

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

goulvench
Copy link
Collaborator

Lors du démarrage de l'application, Devise cherche la clé secrets_key_base dans Rails.application.secrets, ce qui déclenche le message de déprécation suivant :

WARNING: Rails.application.secrets is deprecated in favor of Rails.application.credentials and will be removed in Rails 7.2.

En attendant que Devise corriger le problème, il suffit d'indiquer où trouver cette clé explicitement.

Issue sur Devise

Copy link

gitguardian bot commented Apr 29, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
2912718 Triggered Generic High Entropy Secret 3feae37 config/initializers/devise.rb View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Revoke and rotate the secret.

  2. If possible, rewrite git history with git commit --amend and git push --force.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@bricedurand
Copy link
Collaborator

GitGuardian considère que le secret est écrit en dur, étrange

@goulvench
Copy link
Collaborator Author

GitGuardian considère que le secret est écrit en dur, étrange

C'est le secret généré quand on installe Devise, il est écrit en dur mais commenté. GitGuardian a du être installé après Devise. Je supprime le code commenté en question.

heartcombo/devise#5644

On supprime le secret généré par Devise dans du code commenté parce que GitGuardian s'en offusque.
@goulvench goulvench force-pushed the fix/rails-secrets-deprecation-warning branch from 7989d2f to 3feae37 Compare April 29, 2024 09:08
@bricedurand bricedurand merged commit 2506e57 into main Apr 29, 2024
7 checks passed
@bricedurand bricedurand deleted the fix/rails-secrets-deprecation-warning branch April 29, 2024 09:14
@goulvench goulvench linked an issue May 1, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning
2 participants