Skip to content
This repository has been archived by the owner on May 20, 2020. It is now read-only.

Commit

Permalink
bringing back no-unused-variable (#39)
Browse files Browse the repository at this point in the history
in agreement with palantir/tslint#4100
this ruleset doesn't force people to switch to compile error for getting rid of unused things,
this currently means paying the price of the deprecation warning
  • Loading branch information
karfau authored Sep 20, 2018
1 parent 3c5128d commit 9674d23
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "bm-tslint-rules",
"version": "0.4.0",
"version": "0.5.0",
"description": "default tslint rules to use for projects using typescript",
"repository": "https://github.com/bettermarks/bm-tslint-rules",
"bugs": "https://github.com/bettermarks/bm-tslint-rules/issues",
Expand Down
7 changes: 7 additions & 0 deletions tslint.json
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,13 @@
"allow-fast-null-checks",
"should"
],
"no-unused-variable": [
// in agreement with https://github.com/palantir/tslint/issues/4100
// this ruleset doesn't force people to switch to compile error
// for getting rid of unused things, this currently means
// paying the price of the deprecation warning
true
],
"no-use-before-declare": true,
"no-useless-files": true,
"no-void-expression": false,
Expand Down
7 changes: 7 additions & 0 deletions tslint.report.active.json
Original file line number Diff line number Diff line change
Expand Up @@ -662,6 +662,13 @@
"ruleSeverity": "error",
"source": "tslint-no-unused-expression-chai"
},
"no-unused-variable": {
"deprecated": "Since TypeScript 2.9. Please use the built-in compiler checks instead.",
"documentation": "https://palantir.github.io/tslint/rules/no-unused-variable",
"hasFix": true,
"ruleSeverity": "error",
"source": "tslint"
},
"no-use-before-declare": {
"documentation": "https://palantir.github.io/tslint/rules/no-use-before-declare",
"ruleSeverity": "error",
Expand Down

0 comments on commit 9674d23

Please sign in to comment.