fix: prevent placeholder in runtime for media and tab

bettyblocks · Dec 1, 2020 · c71e948 · c71e948
1 parent 4f11374
commit c71e948
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 13 deletions.
diff --git a/src/components/media.js b/src/components/media.js
@@ -71,14 +71,17 @@
       }
     };
 
-    let MediaComponent = () => (
-      <div className={[(isEmpty || variableDev) && classes.empty]}>
-        <div className={classes.placeholderWrapper}>
-          <Placeholder />
-          {variable && <span>{imgUrl}</span>}
+    let MediaComponent = () => {
+      if (!isDev) return null;
+      return (
+        <div className={[(isEmpty || variableDev) && classes.empty]}>
+          <div className={classes.placeholderWrapper}>
+            <Placeholder />
+            {variable && <span>{imgUrl}</span>}
+          </div>
         </div>
-      </div>
-    );
+      );
+    };
 
     if (isImage && !variableDev) {
       MediaComponent = () => (

diff --git a/src/components/tab.js b/src/components/tab.js
@@ -24,11 +24,14 @@
 
     B.defineFunction('Select', doSetTab);
 
-    const emptyBox = (
-      <Box className={classes.empty} p={3}>
-        Tab
-      </Box>
-    );
+    const EmptyBox = () => {
+      if (!isDev) return null;
+      return (
+        <Box className={classes.empty} p={3}>
+          Tab
+        </Box>
+      );
+    };
 
     const TabPanel = (isActive || !isDev) && (
       <Typography
@@ -37,7 +40,7 @@
         hidden={!isActive}
         aria-labelledby="tabs"
       >
-        {children.length === 0 ? emptyBox : children}
+        {children.length === 0 ? <EmptyBox /> : children}
       </Typography>
     );