Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of try...catch in v4.1 could have impacts in browser environments #18

Closed
balupton opened this issue Feb 1, 2015 · 1 comment
Closed

Removal of try...catch in v4.1 could have impacts in browser environments #18

balupton opened this issue Feb 1, 2015 · 1 comment
Labels
bug Broken or unexpected

Comments

@balupton
Copy link
Member

balupton commented Feb 1, 2015

Just documenting this here as it could be an issue. It's not a panic thing, as browserify shims the domain module to https://github.com/bevry/domain-browser which uses try...catch which would then introduce the #17 issues once more, at least in the browser environment, however that is a lot better than having no try...catch and no domains so no error catching.
@balupton balupton added wontfix bug Broken or unexpected labels Feb 1, 2015
@balupton
Copy link
Member Author

balupton commented Feb 1, 2015

So labelled as wontfix, as we can't fix #17 while keeping try...catch/browser support ourselves. If people wan't any shimming, then that is on their terms and their responsibility (e.g. the browserify shim)

@balupton balupton closed this as completed Feb 1, 2015
balupton added a commit that referenced this issue Feb 2, 2015
@balupton
v4.2.0. Improvement.
fdb440a 
- Reintroduced `try...catch` for Node v0.8 and browser environments
with a workaround to prevent error suppression
	- Thanks to [kksharma1618](https://github.com/kksharma1618) for [issue
	- Closes [issue #18](#17)
- You can now ignore all the warnings from the v4.1.0 changelog as the
behaviour is more or less the same as v4.0.5 but with added improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Broken or unexpected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@balupton