-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always install Rust and use Leafwing-Studios/cargo-cache
#1405
base: main
Are you sure you want to change the base?
Conversation
I'm marking this as contentious because it is pulling in an outside dependency, but I feel like it's from a trusted source. If this gets major pushback, we can fork |
I'm rebasing this on top of #1403 so CI passes. Consider this blocked until that PR is merged. |
Just linking in discussion from the twin PR for the |
Yeah no objection to handing off ownership to the Bevy org if this appeals to y'all :) |
Github hosted runners come preinstalled with Rust[^0], though it is often outdated. We should prefer to manually install it, since it gives us control over the version being used. [^0]: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#rust-tools
@mockersf what are your thoughts on merging this? It would provide a good testing ground for introducing this action to the main Bevy repository, and Alice even offered transferring the repository. |
Note that |
Co-authored-by: Jan Hohenheim <[email protected]>
Let me enable the |
Hah! Turns out this found a bug with |
This PR has two parts:
Leafwing-Studios/cargo-cache
for all jobs that use Rust. This action is wonderful: I've been using it successfully for a month or so now. (Also it's by our friends at Leafwing, so it can be trusted!) This should speed up many jobs without the usual tradeoffs of caching.