Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: gizmo lines with vertices behind camera display artifacts #10403

Closed
aevyrie opened this issue Nov 6, 2023 · 2 comments · Fixed by #10408
Closed

Regression: gizmo lines with vertices behind camera display artifacts #10403

aevyrie opened this issue Nov 6, 2023 · 2 comments · Fixed by #10408
Labels
A-Gizmos Visual editor and debug gizmos A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-Regression Functionality that used to work but no longer does. Add a test for this!
Milestone
0.12.1

Comments

@aevyrie
Copy link
Member

aevyrie commented Nov 6, 2023 •
edited
Loading

Bevy version

Appears in 0.12

App.2023-11-05.22-27-17.mp4

Seems to be related to #9470
@aevyrie aevyrie added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen S-Needs-Triage This issue needs to be labelled A-Gizmos Visual editor and debug gizmos P-Regression Functionality that used to work but no longer does. Add a test for this! labels Nov 6, 2023
@tim-blackbird
Copy link
Contributor

It is the changes in #9470 that are causing issues in the big_space demo. On 0.11.1 it looks fine aside from the lines deforming a little.
Looks like an issue with precision, but these cubes are only 2000 units and close to the center of the world, right?

Well I can reproduce this with a cube of 100 000 units. Definitely an issue with precision, I'll try to improve that.

@tim-blackbird tim-blackbird mentioned this issue Nov 6, 2023
Merged
@aevyrie
Copy link
Member Author

aevyrie commented Nov 6, 2023

Yes, these cubes are small and close to the origin. I was not seeing this issue on 11.3 fwiw.

@cart cart added this to the 0.12.1 milestone Nov 6, 2023
@nicopap nicopap removed the S-Needs-Triage This issue needs to be labelled label Nov 7, 2023
github-merge-queue bot pushed a commit that referenced this issue Nov 14, 2023
@tim-blackbird
Fix float precision issue in the gizmo shader (#10408)
7b2213a 
Fix a precision issue with in the manual near-clipping function.
This only affected lines that span large distances (starting at 100_000~
units) in my testing.

Fixes #10403
cart pushed a commit that referenced this issue Nov 30, 2023
@tim-blackbird @cart
Fix float precision issue in the gizmo shader (#10408)
a3a7376 
Fix a precision issue with in the manual near-clipping function.
This only affected lines that span large distances (starting at 100_000~
units) in my testing.

Fixes #10403
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this issue Jan 9, 2024
@tim-blackbird
Fix float precision issue in the gizmo shader (bevyengine#10408)
772adcd 
Fix a precision issue with in the manual near-clipping function.
This only affected lines that span large distances (starting at 100_000~
units) in my testing.

Fixes bevyengine#10403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Gizmos Visual editor and debug gizmos A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-Regression Functionality that used to work but no longer does. Add a test for this!
Projects
None yet
Milestone
0.12.1
Development

Successfully merging a pull request may close this issue.

Fix float precision issue in the gizmo shader tim-blackbird/bevy
4 participants
@aevyrie @cart @nicopap @tim-blackbird