-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shader hot reloading no longer works for locally imported shaders #10500
Comments
Edit: I misread. This is a different issue. |
Have you enabled the |
I have enabled the 2023-11-10T22:44:27.261541Z ERROR bevy_render::render_resource::pipeline_cache: failed to process shader:
error: required import '"shaders/custom_material_import.wgsl"' not found
┌─ shaders/custom_material.wgsl:17:94
│
17 │ return material.color * textureSample(base_color_texture, base_color_sampler, mesh.uv) * COLOR_MULTIPLIER;
│ ^
│
= missing import '"shaders/custom_material_import.wgsl"' |
Very strange. This is what I ran:
I can change either file, add new imports, etc and it all works. I'm on linux. |
# Objective Hot reloading shader imports on windows is currently broken due to inconsistent `/` and `\` usage ('/` is used in the user facing APIs and `\` is produced by notify-rs (and likely other OS apis). Fixes #10500 ## Solution Standardize import paths when loading a `Shader`. The correct long term fix is to standardize AssetPath on `/`-only, but this is the right scope of fix for a patch release. --------- Co-authored-by: François <[email protected]>
# Objective Hot reloading shader imports on windows is currently broken due to inconsistent `/` and `\` usage ('/` is used in the user facing APIs and `\` is produced by notify-rs (and likely other OS apis). Fixes #10500 ## Solution Standardize import paths when loading a `Shader`. The correct long term fix is to standardize AssetPath on `/`-only, but this is the right scope of fix for a patch release. --------- Co-authored-by: François <[email protected]>
# Objective Hot reloading shader imports on windows is currently broken due to inconsistent `/` and `\` usage ('/` is used in the user facing APIs and `\` is produced by notify-rs (and likely other OS apis). Fixes bevyengine#10500 ## Solution Standardize import paths when loading a `Shader`. The correct long term fix is to standardize AssetPath on `/`-only, but this is the right scope of fix for a patch release. --------- Co-authored-by: François <[email protected]>
Bevy version 0.12
In 0.11 it was possible to hot reload locally imported shaders. This no longer works in 0.12.
If I try to edit
shaders/bar.wgsl
I get:The text was updated successfully, but these errors were encountered: