Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purdue Refactoring - PBR Related PRs #12349

Open
nbielans opened this issue Mar 6, 2024 · 0 comments
Open

Purdue Refactoring - PBR Related PRs #12349

nbielans opened this issue Mar 6, 2024 · 0 comments
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change C-Feature A new feature, making something new possible C-Tracking-Issue An issue that collects information about a broad development initiative

Comments

@nbielans
Copy link
Contributor

nbielans commented Mar 6, 2024

What problem does this solve or what need does it fill?

An issue for PRs related to the refactoring of any bevy_pbr related PR's for the Purdue refactoring team to link to.

What solution would you like?

Currently focusing on refactoring of src/light.rs in bevy_pbr

hack.md document containing further plans

Additional context

We are a team of students in a Grad-level course at Purdue that will be contributing to Bevy over the course of our semester until the end of April. nbielans and lamalmeida are the two who are focusing on this.
@nbielans nbielans added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Mar 6, 2024
@TrialDragon TrialDragon added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change C-Tracking-Issue An issue that collects information about a broad development initiative and removed S-Needs-Triage This issue needs to be labelled labels Mar 6, 2024
@alice-i-cecile alice-i-cecile mentioned this issue Mar 7, 2024
Closed
16 tasks
@nbielans nbielans mentioned this issue Mar 7, 2024
Merged
@lamalmeida lamalmeida mentioned this issue Mar 9, 2024
Closed
github-merge-queue bot pushed a commit that referenced this issue Mar 13, 2024
@nbielans
Extracting ambient light from light.rs, and creating light directory (#…
e282ee1 
…12369)

# Objective
Beginning of refactoring of light.rs in bevy_pbr, as per issue #12349 
Create and move light.rs to its own directory, and extract AmbientLight
struct.

## Solution

- moved light.rs to light/mod.rs
- extracted AmbientLight struct to light/ambient_light.rs
@nbielans nbielans mentioned this issue Mar 22, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 23, 2024
@nbielans
Moving structs PointLight, SpotLight, and DirectionalLight out of lig…
d836ece 
…ht/mod.rs (#12656)

# Objective

Follow up from PR #12369 to extract lighting structs from light/mod.rs
into their own file.
Part of the Purdue Refactoring Team's goals issue #12349 

## Solution

- Moved PointLight from light/mod.rs to light/point_light.rs
- Moved SpotLight from light/mod.rs to light/spot_light.rs
- Moved DirectionalLight from light/mod.rs to light/directional_light.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change C-Feature A new feature, making something new possible C-Tracking-Issue An issue that collects information about a broad development initiative
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TrialDragon @nbielans