Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hsva and Hwba colors do not implement Mix #12618

Closed
alice-i-cecile opened this issue Mar 21, 2024 · 0 comments · Fixed by #12619
Closed

Hsva and Hwba colors do not implement Mix #12618

alice-i-cecile opened this issue Mar 21, 2024 · 0 comments · Fixed by #12619
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy
Milestone
0.14

Comments

@alice-i-cecile
Copy link
Member

What problem does this solve or what need does it fill?

Hsla implements Mix, our trait for color blending. Its sibling color types (Hsva and Hwba) should do likewise.

What solution would you like?

Follow the implementation in Hsla to implement this trait.

Additional context

Found and reported by Lumen on Discord.
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Mar 21, 2024
@alice-i-cecile alice-i-cecile added this to the 0.14 milestone Mar 21, 2024
@lynn-lumen lynn-lumen mentioned this issue Mar 21, 2024
Merged
@alice-i-cecile alice-i-cecile mentioned this issue Mar 21, 2024
Closed
github-merge-queue bot pushed a commit that referenced this issue Mar 22, 2024
@lynn-lumen
Implement Mix for Hsva and Hwba (#12619)
7673afb 
# Objective

- Fixes #12618

## Solution

- Implemented `Mix` for `Hsva` and `Hwba` following the implementation
approach of `Hsla`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
0.14
Development

Successfully merging a pull request may close this issue.

Implement Mix for Hsva and Hwba lynn-lumen/bevy
1 participant
@alice-i-cecile