Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Periodically check Bevy's CI against the beta Rust channel #12625

Closed
alice-i-cecile opened this issue Mar 21, 2024 · 3 comments · Fixed by #12763
Closed

Periodically check Bevy's CI against the beta Rust channel #12625

alice-i-cecile opened this issue Mar 21, 2024 · 3 comments · Fixed by #12763
Labels
A-Build-System Related to build systems or continuous integration C-Feature A new feature, making something new possible

Comments

@alice-i-cecile
Copy link
Member

What problem does this solve or what need does it fill?

Most Rust releases, our CI breaks as new lints are stabilized, diagnostics change, or causing confusion and work stoppage.

See #12620 for the latest.

What solution would you like?

Run all CI jobs against the beta channel of Rust every week.

It's not clear to me the best way to accomplish this or report it to the community at large. IIRC, Github's built-in feature for this only notifies a single person. Filing and tagging an issue would be ideal.

What alternative(s) have you considered?

Add more checks to CI.

This adds even more time to our already long CI jobs, and will confuse contributors due to failing changes in unrelated code.
@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible A-Build-System Related to build systems or continuous integration labels Mar 21, 2024
@alice-i-cecile alice-i-cecile mentioned this issue Mar 21, 2024
Closed
@Brezak
Copy link
Contributor

Brezak commented Mar 21, 2024

There's a github action to create an issue, but I don't know if handing it our github token is a good idea safety wise.

@mockersf
Copy link
Member

this doc shows how to open an issue without depending on a custom action

@DJMcNab
Copy link
Member

DJMcNab commented Mar 21, 2024

My suggestion for this is to use discord webhooks

(I've been meaning to set the same thing up for Linebender, although of course with Zulip webhooks instead)

@Brezak Brezak mentioned this issue Mar 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Mar 31, 2024
@Brezak
Check CI against Rust beta each week (#12763)
ec7755d 
# Objective

Get an early warning if any new rust lints will break CI. Closes #12625

## Solution

Test the main branch against the Rust beta every week.

## Additional Possibilities
The action currently creates an issue if anything fails. The issue could
use a label like `C-Weekly` but somebody with the ability to create
issue labels would have to add it.

Another possibility would be to use discord webhooks. That would need
somebody with the access to create webhooks on discord and somebody with
the rights to connect that webhook to this repo,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Feature A new feature, making something new possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check CI against Rust beta each week Brezak/bevy
4 participants
@alice-i-cecile @mockersf @DJMcNab @Brezak