Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rem_euclid consistently throughout bevy_color #12631

Closed
alice-i-cecile opened this issue Mar 21, 2024 · 0 comments · Fixed by #12641
Closed

Use rem_euclid consistently throughout bevy_color #12631

alice-i-cecile opened this issue Mar 21, 2024 · 0 comments · Fixed by #12641
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@alice-i-cecile
Copy link
Member

What problem does this solve or what need does it fill?

Some of the early code by @viridia that works with hues implements rem_euclid manually.

What solution would you like?

Use the rem_euclid method on f32 directly.
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change labels Mar 21, 2024
@viridia viridia mentioned this issue Mar 22, 2024
Closed
viridia added a commit to viridia/bevy that referenced this issue Mar 22, 2024
@viridia
Interpolating hues should use rem_euclid.
f3efd01 
Also, added additional tests for the hue interpolation.

Fixes bevyengine#12632
Fixes bevyengine#12631
@viridia viridia mentioned this issue Mar 22, 2024
Merged
viridia added a commit to viridia/bevy that referenced this issue Mar 22, 2024
@viridia
Interpolating hues should use rem_euclid.
e6a0538 
Also, added additional tests for the hue interpolation.

Fixes bevyengine#12632
Fixes bevyengine#12631
github-merge-queue bot pushed a commit that referenced this issue Mar 22, 2024
@viridia
Interpolating hues should use rem_euclid. (#12641)
7133d51 
Also, added additional tests for the hue interpolation.

Fixes #12632
Fixes #12631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Interpolating hues should use rem_euclid. viridia/bevy
1 participant
@alice-i-cecile