Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WireFrameColor component ignored #13032

Closed
galop1n opened this issue Apr 19, 2024 · 1 comment · Fixed by #13034
Closed

WireFrameColor component ignored #13032

galop1n opened this issue Apr 19, 2024 · 1 comment · Fixed by #13034
Labels
A-Gizmos Visual editor and debug gizmos C-Bug An unexpected or incorrect behavior

Comments

@galop1n
Copy link

galop1n commented Apr 19, 2024

Bevy version

0.13.2

What you did

Add WireframeColor to various PbrBundle
Set default_color to yellow in WireframeConfig
Set global to true in WireframeConfig

What went wrong

WireframeColor is ignored and all wireframe is yellow as set in the global config. Documentation state that in the absence of the Wireframe component, it should still influence the wire color when global is set to true.

  • what were you expecting?

The wire color of the pbr bundle should be the one set the WireframeColor component.

  • what actually happened?

All PbrBundle used the global default color from WireframeConfig

Additional information

If I add the Wireframe component, the color is properly applied to the wireframe.
@galop1n galop1n added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Apr 19, 2024
@IceSentry IceSentry mentioned this issue Apr 19, 2024
Merged
@IceSentry
Copy link
Contributor

This will be fixed by #13034

@alice-i-cecile alice-i-cecile added A-Gizmos Visual editor and debug gizmos and removed S-Needs-Triage This issue needs to be labelled labels Apr 20, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 20, 2024
@IceSentry
Use WireframeColor to override global color (#13034)
8403c41 
# Objective

- The docs says the WireframeColor is supposed to override the default
global color but it doesn't.

## Solution

- Use WireframeColor to override global color like docs said it was
supposed to do.
- Updated the example to document this feature
- I also took the opportunity to clean up the code a bit

Fixes #13032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Gizmos Visual editor and debug gizmos C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use WireframeColor to override global color IceSentry/bevy
3 participants
@alice-i-cecile @galop1n @IceSentry