Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check-cfg when Rust 1.80 is released #13268

Closed
BD103 opened this issue May 7, 2024 · 0 comments · Fixed by #14477
Closed

Remove check-cfg when Rust 1.80 is released #13268

BD103 opened this issue May 7, 2024 · 0 comments · Fixed by #14477
Labels
A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Blocked This cannot move forward until something else changes X-Uncontroversial This work is generally agreed upon

Comments

@BD103
Copy link
Member

BD103 commented May 7, 2024

-Zcheck-cfg has been stabilized-ish! (rust-lang/cargo#13571) When Rust 1.80 is released, the separate Github Action job can be removed.

For now, we have two more releases (12 weeks or ~4 months) before this can be done. 💤

check-cfg:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v4
- uses: actions/cache@v4
with:
path: |
~/.cargo/bin/
~/.cargo/registry/index/
~/.cargo/registry/cache/
~/.cargo/git/db/
target/
key: ${{ runner.os }}-check-doc-${{ hashFiles('**/Cargo.toml') }}
- uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ env.NIGHTLY_TOOLCHAIN }}
- name: Install Linux dependencies
uses: ./.github/actions/install-linux-deps
with:
wayland: true
xkb: true
- name: Build and check cfg typos
# See tools/ci/src/main.rs for the commands this runs
run: cargo run -p ci -- cfg-check

@BD103 BD103 added D-Trivial Nice and easy! A great choice to get started with Bevy A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change S-Blocked This cannot move forward until something else changes X-Uncontroversial This work is generally agreed upon labels May 7, 2024
@BD103 BD103 assigned BD103 and unassigned BD103 May 7, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 25, 2024
# Objective

- Fixes #13268

## Solution

- Remove the job as it's now part of rust stable
https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html#checked-cfg-names-and-values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Blocked This cannot move forward until something else changes X-Uncontroversial This work is generally agreed upon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant