Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MainScheduleOrder::insert_before() #13866

Closed
JMS55 opened this issue Jun 15, 2024 · 3 comments · Fixed by #13941
Closed

Add MainScheduleOrder::insert_before() #13866

JMS55 opened this issue Jun 15, 2024 · 3 comments · Fixed by #13941
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon

Comments

@JMS55
Copy link
Contributor

JMS55 commented Jun 15, 2024

What problem does this solve or what need does it fill?

Complements MainScheduleOrder::insert_after().

Additional context

I'd like to add a new schedule before First, as it's something I really want to run before any other system.
@JMS55 JMS55 added C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events labels Jun 15, 2024
@alice-i-cecile
Copy link
Member

While we're here, we should add equivalents for the startup and FixedMain schedule orders.

@alice-i-cecile alice-i-cecile added X-Uncontroversial This work is generally agreed upon S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! labels Jun 16, 2024
@kettei-sproutty
Copy link
Contributor

Hi, I will take this if nobody is working on it :)

@JMS55
Copy link
Contributor Author

JMS55 commented Jun 19, 2024

Please do!

@kettei-sproutty kettei-sproutty mentioned this issue Jun 20, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 20, 2024
@kettei-sproutty
feat: add insert_after and insert_startup_before (#13941)
2f9c42b 
# Objective

Fixes #13866 

## Solution

Add `insert_before` in **FixedMainScheduleOrder** and
**MainScheduleOrder**, add `insert_startup_before` in
**MainScheduleOrder**, applying the same logic as `insert_after`, except
for parameters naming and insertion index.
mockersf pushed a commit that referenced this issue Aug 2, 2024
@kettei-sproutty @mockersf
feat: add insert_after and insert_startup_before (#13941)
61c683f 
# Objective

Fixes #13866 

## Solution

Add `insert_before` in **FixedMainScheduleOrder** and
**MainScheduleOrder**, add `insert_startup_before` in
**MainScheduleOrder**, applying the same logic as `insert_after`, except
for parameters naming and insertion index.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add insert_after and insert_startup_before kettei-sproutty/bevy
3 participants
@alice-i-cecile @JMS55 @kettei-sproutty