Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bevy StateTransitionSteps set is registered in app methods instead of states plugin #13920

Closed
MiniaczQ opened this issue Jun 19, 2024 · 1 comment · Fixed by #13939
Closed

Bevy StateTransitionSteps set is registered in app methods instead of states plugin #13920

MiniaczQ opened this issue Jun 19, 2024 · 1 comment · Fixed by #13939
Labels
A-App Bevy apps and plugins A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@MiniaczQ
Copy link
Contributor

Problem

Anything added to system set StateTransitionSteps before state-related app calls will not be ordered correctly.

Solution

Move setup_state_transitions_in_world(self.world_mut(), Some(Startup.intern())); to StatesPlugin from app methods.
@MiniaczQ MiniaczQ added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jun 19, 2024
@MiniaczQ
Copy link
Contributor Author

It's a quick fix, I'll post a PR tomorrow

@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events A-App Bevy apps and plugins S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! and removed S-Needs-Triage This issue needs to be labelled labels Jun 19, 2024
@MiniaczQ MiniaczQ mentioned this issue Jun 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 20, 2024
@MiniaczQ
Move StateTransitionSteps registration to states plugin (#13939)
31af724 
# Objective

Fixes #13920

## Solution

As described in the issue.

## Testing

Moved a custom transition plugin in example before any of the app-state
methods.
mockersf pushed a commit that referenced this issue Jun 21, 2024
@MiniaczQ @mockersf
Move StateTransitionSteps registration to states plugin (#13939)
783fc29 
# Objective

Fixes #13920

## Solution

As described in the issue.

## Testing

Moved a custom transition plugin in example before any of the app-state
methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-App Bevy apps and plugins A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move StateTransitionSteps registration to states plugin MiniaczQ/bevy
2 participants
@alice-i-cecile @MiniaczQ