Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some examples should actually tint the image color #14120

Closed
alice-i-cecile opened this issue Jul 3, 2024 · 1 comment · Fixed by #14121
Closed

Some examples should actually tint the image color #14120

alice-i-cecile opened this issue Jul 3, 2024 · 1 comment · Fixed by #14121
Assignees
@alice-i-cecile
Labels
C-Examples An addition or correction to our examples
Milestone
0.14

Comments

@alice-i-cecile
Copy link
Member 

          @mockersf @alice-i-cecile This seems incorrect, In those examples I used to tint the image color, not the square background color
Screenshot 2024-07-03 at 09 51 31

Originally posted by @ManevilleF in #14115 (comment)
@alice-i-cecile alice-i-cecile added this to the 0.14 milestone Jul 3, 2024
@alice-i-cecile alice-i-cecile self-assigned this Jul 3, 2024
@alice-i-cecile alice-i-cecile added the C-Examples An addition or correction to our examples label Jul 3, 2024
@rparrett rparrett mentioned this issue Jul 3, 2024
Merged
@rparrett
Copy link
Contributor

rparrett commented Jul 3, 2024

Partial revert PR: #14121

github-merge-queue bot pushed a commit that referenced this issue Jul 3, 2024
@rparrett
Fix border color in ui_texture_slice and ui_texture_atlas_slice e…
c8d8ea6 
…xamples. (#14121)

# Objective

Fixes #14120

`ui_texture_slice` and `ui_texture_atlas_slice` were working as
intended, so undo the changes.

## Solution

Partially revert #14115 for
`ui_texture_slice` and `ui_texture_atlas_slice`.

## Testing

Ran those two examples, confirmed the border color is the thing that
changes when buttons are hovered.
mockersf pushed a commit that referenced this issue Jul 3, 2024
@rparrett @mockersf
Fix border color in ui_texture_slice and ui_texture_atlas_slice e…
201dd62 
…xamples. (#14121)

# Objective

Fixes #14120

`ui_texture_slice` and `ui_texture_atlas_slice` were working as
intended, so undo the changes.

## Solution

Partially revert #14115 for
`ui_texture_slice` and `ui_texture_atlas_slice`.

## Testing

Ran those two examples, confirmed the border color is the thing that
changes when buttons are hovered.
zmbush pushed a commit to zmbush/bevy that referenced this issue Jul 3, 2024
@rparrett @zmbush
Fix border color in ui_texture_slice and ui_texture_atlas_slice e…
ab2b04f 
…xamples. (bevyengine#14121)

# Objective

Fixes bevyengine#14120

`ui_texture_slice` and `ui_texture_atlas_slice` were working as
intended, so undo the changes.

## Solution

Partially revert bevyengine#14115 for
`ui_texture_slice` and `ui_texture_atlas_slice`.

## Testing

Ran those two examples, confirmed the border color is the thing that
changes when buttons are hovered.
MrGVSV pushed a commit to MrGVSV/bevy that referenced this issue Jul 5, 2024
@rparrett @MrGVSV
Fix border color in ui_texture_slice and ui_texture_atlas_slice e…
401fa35 
…xamples. (bevyengine#14121)

# Objective

Fixes bevyengine#14120

`ui_texture_slice` and `ui_texture_atlas_slice` were working as
intended, so undo the changes.

## Solution

Partially revert bevyengine#14115 for
`ui_texture_slice` and `ui_texture_atlas_slice`.

## Testing

Ran those two examples, confirmed the border color is the thing that
changes when buttons are hovered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alice-i-cecile alice-i-cecile

Labels
C-Examples An addition or correction to our examples
Projects
None yet
Milestone
0.14
Development

Successfully merging a pull request may close this issue.

Fix border color in ui_texture_slice and ui_texture_atlas_slice examples. rparrett/bevy
2 participants
@rparrett @alice-i-cecile