Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bevy_image re-exports from bevy_render #15940

Closed
andriyDev opened this issue Oct 16, 2024 · 0 comments · Fixed by #16163
Closed

Remove bevy_image re-exports from bevy_render #15940

andriyDev opened this issue Oct 16, 2024 · 0 comments · Fixed by #16163
Assignees
@BenjaminBrienen
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Milestone
0.16

Comments

@andriyDev
Copy link
Contributor

What problem does this solve or what need does it fill?

Currently, bevy_render re-exports everything from bevy_image. This means users may be accidentally using bevy_render in cases where they only need bevy_image.

What solution would you like?

Remove the bevy_image re-exports from bevy_render!

What alternative(s) have you considered?

Do nothing. Currently users still have to add the ImagePlugin through bevy_render, so using Image through it is also fine.

Additional context

This should be deferred to 0.16, to ease the migration due to #15650.
@andriyDev andriyDev added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Oct 16, 2024
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples and removed C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Oct 16, 2024
@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Oct 16, 2024
@BenjaminBrienen BenjaminBrienen self-assigned this Oct 30, 2024
@BenjaminBrienen BenjaminBrienen added the S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! label Oct 30, 2024
@BenjaminBrienen BenjaminBrienen mentioned this issue Oct 30, 2024
Merged
@BenjaminBrienen BenjaminBrienen mentioned this issue Nov 7, 2024
Closed
github-merge-queue bot pushed a commit that referenced this issue Nov 10, 2024
@BenjaminBrienen @chompaa @cart
Don't reëxport bevy_image from bevy_render (#16163)
40640fd 
# Objective

Fixes #15940

## Solution

Remove the `pub use` and fix the compile errors.
Make `bevy_image` available as `bevy::image`.

## Testing

Feature Frenzy would be good here! Maybe I'll learn how to use it if I
have some time this weekend, or maybe a reviewer can use it.

## Migration Guide

Use `bevy_image` instead of `bevy_render::texture` items.

---------

Co-authored-by: chompaa <[email protected]>
Co-authored-by: Carter Anderson <[email protected]>
mockersf pushed a commit that referenced this issue Nov 11, 2024
@BenjaminBrienen @chompaa
@cart @mockersf
Don't reëxport bevy_image from bevy_render (#16163)
31ec575 
Fixes #15940

Remove the `pub use` and fix the compile errors.
Make `bevy_image` available as `bevy::image`.

Feature Frenzy would be good here! Maybe I'll learn how to use it if I
have some time this weekend, or maybe a reviewer can use it.

Use `bevy_image` instead of `bevy_render::texture` items.

---------

Co-authored-by: chompaa <[email protected]>
Co-authored-by: Carter Anderson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenjaminBrienen BenjaminBrienen

Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
0.16
Development

Successfully merging a pull request may close this issue.

Don't reëxport bevy_image from bevy_render BenjaminBrienen/bevy
3 participants
@alice-i-cecile @andriyDev @BenjaminBrienen