Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bevy 0.4 -> 0.5 broke aarch64-unknown-linux-gnu #1942

Closed
skhameneh opened this issue Apr 16, 2021 · 2 comments
Closed

Bevy 0.4 -> 0.5 broke aarch64-unknown-linux-gnu #1942

skhameneh opened this issue Apr 16, 2021 · 2 comments
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Dependencies A change to the crates that Bevy depends on O-Linux Specific to the Linux desktop operating system

Comments

@skhameneh
Copy link

skhameneh commented Apr 16, 2021 •
edited
Loading

On armv8.2a, 0.5 fails on bevy-glsl-to-spirv not supporting aarch64-unknown-linux-gnu.
I added aarch64-unknown-linux-gnu to the supported platforms locally for bevy-glsl-to-spirv and bevy-glsl-to-spirv will build, but bevy fails on linking with various glsl components.

It's not clear if Bevy 0.4 was using shaderc or something else in bevy_render broke the build.
@skhameneh skhameneh added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Apr 16, 2021
@alice-i-cecile alice-i-cecile added O-Linux Specific to the Linux desktop operating system and removed S-Needs-Triage This issue needs to be labelled labels Apr 16, 2021
@skhameneh skhameneh changed the title Bevy 0.4 -> 0.5 broke aarch64-linux Bevy 0.4 -> 0.5 broke aarch64-unknown-linux-gnu Apr 16, 2021
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Dependencies A change to the crates that Bevy depends on labels Apr 16, 2021
@MinerSebas
Copy link
Contributor

Bevy 0.4 should have never been able to successfully compile on aarch64-unknown-linux-gnu, as Bevy currently uses bevy-glsl-to-spirv, except for ios and aarch64 macos where shaderc is used instead.

This Issue can be closed once #1819 makes shaderc the Default.

@MinerSebas MinerSebas mentioned this issue Apr 16, 2021
Closed
@skhameneh
Copy link
Author

Confirming a46c35a from #1819 fixes this issue.

@bors bors bot closed this as completed in f1ddd7a Apr 19, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this issue Jul 27, 2021
@mockersf @ostwilkens
change how to select bevy-glsl-to-spirv or shaderc (bevyengine#1819)
0f04d08 
`cfg` for `bevy-glsl-to-spirv` use now mimics https://github.com/cart/glsl-to-spirv/blob/master/Cargo.toml

fixes bevyengine#898 
fixes bevyengine#1348 
fixes bevyengine#1942 
fixes bevyengine#1078
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Dependencies A change to the crates that Bevy depends on O-Linux Specific to the Linux desktop operating system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - change how to select bevy-glsl-to-spirv or shaderc mockersf/bevy
3 participants
@skhameneh @alice-i-cecile @MinerSebas