Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dead link tracking #1983

Open
3 tasks
mockersf opened this issue Apr 22, 2021 · 1 comment
Open
3 tasks

dead link tracking #1983

mockersf opened this issue Apr 22, 2021 · 1 comment
Labels
C-Bug An unexpected or incorrect behavior C-Docs An addition or correction to our documentation

Comments

@mockersf
Copy link
Member

Currently dead link check is enabled but doesn't fail in CI due to a lot of dead links. See #1590

  • Linked file at path struct.Span.html does not exist! will be fixed in tracing v0.2
  • into_any* and as_any* comes from an issue in how downcast-rs is built/documented?
  • sort_by_key should be solved by rust 1.52
@mockersf mockersf added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Apr 22, 2021
@mockersf mockersf mentioned this issue Apr 22, 2021
Closed
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation and removed S-Needs-Triage This issue needs to be labelled labels Apr 22, 2021
@mnmaita
Copy link
Member

mnmaita commented Mar 30, 2024

I assume item number 3 is now resolved, but what about the issue with downcast-rs?

@SkiFire13 SkiFire13 mentioned this issue Jun 30, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 11, 2024
@SkiFire13
Fix intra-doc links and make CI test them (#14076)
d708036 
# Objective

- Bevy currently has lot of invalid intra-doc links, let's fix them!
- Also make CI test them, to avoid future regressions.
- Helps with #1983 (but doesn't fix it, as there could still be explicit
links to docs.rs that are broken)

## Solution

- Make `cargo r -p ci -- doc-check` check fail on warnings (could also
be changed to just some specific lints)
- Manually fix all the warnings (note that in some cases it was unclear
to me what the fix should have been, I'll try to highlight them in a
self-review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Bug An unexpected or incorrect behavior C-Docs An addition or correction to our documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alice-i-cecile @mockersf @mnmaita