Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serialize feature to bevy_transform #6378

Closed
amiani opened this issue Oct 26, 2022 · 0 comments
Closed

Add serialize feature to bevy_transform #6378

amiani opened this issue Oct 26, 2022 · 0 comments
Labels
A-Transform Translations, rotations and scales C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@amiani
Copy link
Contributor

amiani commented Oct 26, 2022

What problem does this solve or what need does it fill?

bevy_transform is missing a feature corresponding to the top-level serialize feature. This makes it inconsistent with bevy_input, bevy_time, etc. and makes serializing Transforms with serde a non-trivial task.

What solution would you like?

Transform and GlobalTransform implement serde::Serialize and serde::Deserialize when serialize feature is enabled.

What alternative(s) have you considered?

This can often be worked around by using serde's remote def method.
@amiani amiani added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Oct 26, 2022
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Transform Translations, rotations and scales and removed C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Oct 26, 2022
@amiani amiani mentioned this issue Oct 26, 2022
Closed
@Shatur Shatur mentioned this issue Oct 30, 2022
Closed
@bors bors bot closed this as completed in bf6c457 Oct 31, 2022
bors bot pushed a commit that referenced this issue Oct 31, 2022
@Shatur
Add serialize feature to bevy_core (#6423)
87d4c63 
# Objective

`bevy_core` is missing a feature corresponding to the `serialize` feature on the `bevy` crate. Similar to #6378 and #6379 to serialize `Name` easily.

## Solution

Add this feature and hand-written serialization for `Name` (to avoid storing `hash` field).

---

## Changelog

### Added

* `Serialize` and `Deserialize` derives for `Name` under `serialize` feature.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@amiani @ItsDoot
add serialize feature to bevy_transform (bevyengine#6379)
f1721a2 
# Objective
Fixes bevyengine#6378 
`bevy_transform` is missing a feature corresponding to the `serialize` feature on the `bevy` crate.

## Solution

Adds a `serialize` feature to `bevy_transform`.
Derives `serde::Serialize` and `Deserialize` when feature is enabled.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@Shatur @ItsDoot
Add serialize feature to bevy_core (bevyengine#6423)
5a8e6e4 
# Objective

`bevy_core` is missing a feature corresponding to the `serialize` feature on the `bevy` crate. Similar to bevyengine#6378 and bevyengine#6379 to serialize `Name` easily.

## Solution

Add this feature and hand-written serialization for `Name` (to avoid storing `hash` field).

---

## Changelog

### Added

* `Serialize` and `Deserialize` derives for `Name` under `serialize` feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Transform Translations, rotations and scales C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - add serialize feature to bevy_transform amiani/bevy
2 participants
@alice-i-cecile @amiani