-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Msaa to a component, instead of a resource #7194
Comments
I take it this should be a component on individual cameras? |
Yes, aligning with how all the other rendering stuff is now per-camera. |
from #7215, msaa configuration should not be on the camera but on the window |
Also ideally it shouldn't be another component, but just added to the Window component here: bevy/crates/bevy_window/src/window.rs Lines 96 to 163 in 884ebbf
|
A real world example where MSAA can be used in the camera, but not in the whole window: The portraits at the top left are a separate realtime scene. Sometimes you may want a better quality for them than the world map. Using separate MSAA settings for each camera makes it easier to reimplement something like this in bevy. |
@JMS55 can you polish up the description and migration guide for this? |
Switches `Msaa` from being a globally configured resource to a per camera view component. Closes bevyengine#7194
Switches `Msaa` from being a globally configured resource to a per camera view component. Closes #7194 # Objective Allow individual views to describe their own MSAA settings. For example, when rendering to different windows or to different parts of the same view. ## Solution Make `Msaa` a component that is required on all camera bundles. ## Testing Ran a variety of examples to ensure that nothing broke. TODO: - [ ] Make sure android still works per previous comment in `extract_windows`. --- ## Migration Guide `Msaa` is no longer configured as a global resource, and should be specified on each spawned camera if a non-default setting is desired. --------- Co-authored-by: Alice Cecile <[email protected]> Co-authored-by: François Mockers <[email protected]>
No description provided.
The text was updated successfully, but these errors were encountered: