Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MSAA with 2x and 8x samples #7295

Closed
wilk10 opened this issue Jan 20, 2023 · 3 comments
Closed

Support MSAA with 2x and 8x samples #7295

wilk10 opened this issue Jan 20, 2023 · 3 comments
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible
Milestone

Comments

@wilk10
Copy link
Contributor

wilk10 commented Jan 20, 2023

What problem does this solve or what need does it fill?

When checking out #7292 i noticed that the linked WGPU issue ( gfx-rs/wgpu#1832 ) has been closed by gfx-rs/wgpu#3140 .

The WGPU issue is linked in this comment, which I think is really visible to new users because adding the Msaa resource is one of the first settings new users learn, imo.

I'm not 100% sure what is needed in Bevy to support them, beyond offering the option to set these values, but I've seen issues being opened around trying to the the samples count to something other than 1x and 4x, and Cart has said it's something Bevy should support.

What solution would you like?

Bevy should support setting the MSAA samples count to 2x and 8x as well. Ideally by adding them to the enum introduced in #7292 (if that gets merged, it seems the preferred solution based on this other comment by Cart).

What alternative(s) have you considered?

At the very least imo the linked comment should reference this internal issue instead of the WGPU one, until there's support for 2x and 8x samples in Bevy.

Additional context

Nothing else.

@wilk10 wilk10 added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Jan 20, 2023
@tim-blackbird
Copy link
Contributor

The issue is closed, but wgpu has not released a new version yet so we are still blocked on wgpu.

@james7132 james7132 added A-Rendering Drawing game state to the screen S-Blocked This cannot move forward until something else changes and removed S-Needs-Triage This issue needs to be labelled labels Jan 20, 2023
@wilk10
Copy link
Contributor Author

wilk10 commented Feb 6, 2023

Now that Bevy has upgraded on main to wgpu 0.15, is this unblocked?

@Hellzbellz123
Copy link

Now that Bevy has upgraded on main to wgpu 0.15, is this unblocked?

should be as simple as updating the msaa struct with more variants, i have a local copy im testing on. currently i have x4 x8 x16, i do not know if theres others that should be used OR if we want too go back too the older system of specifying ints. tho i doubt theres much point above x16, heck proably even x8
someone with more experience should probably decide on that

@JMS55 JMS55 added this to the 0.10 milestone Feb 11, 2023
@JMS55 JMS55 removed the S-Blocked This cannot move forward until something else changes label Feb 11, 2023
@bors bors bot closed this as completed in c5d2d1a Feb 17, 2023
myreprise1 pushed a commit to myreprise1/bevy that referenced this issue Feb 18, 2023
# Objective
Fixes bevyengine#7295 

Should we maybe default to 4x if 2x/8x is selected but not supported?

---

## Changelog
- Added 2x and 8x sample counts for MSAA.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants