You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The WGPU issue is linked in this comment, which I think is really visible to new users because adding the Msaa resource is one of the first settings new users learn, imo.
I'm not 100% sure what is needed in Bevy to support them, beyond offering the option to set these values, but I've seen issues being opened around trying to the the samples count to something other than 1x and 4x, and Cart has said it's something Bevy should support.
What solution would you like?
Bevy should support setting the MSAA samples count to 2x and 8x as well. Ideally by adding them to the enum introduced in #7292 (if that gets merged, it seems the preferred solution based on this other comment by Cart).
What alternative(s) have you considered?
At the very least imo the linked comment should reference this internal issue instead of the WGPU one, until there's support for 2x and 8x samples in Bevy.
Additional context
Nothing else.
The text was updated successfully, but these errors were encountered:
Now that Bevy has upgraded on main to wgpu 0.15, is this unblocked?
should be as simple as updating the msaa struct with more variants, i have a local copy im testing on. currently i have x4 x8 x16, i do not know if theres others that should be used OR if we want too go back too the older system of specifying ints. tho i doubt theres much point above x16, heck proably even x8
someone with more experience should probably decide on that
# Objective
Fixesbevyengine#7295
Should we maybe default to 4x if 2x/8x is selected but not supported?
---
## Changelog
- Added 2x and 8x sample counts for MSAA.
What problem does this solve or what need does it fill?
When checking out #7292 i noticed that the linked WGPU issue ( gfx-rs/wgpu#1832 ) has been closed by gfx-rs/wgpu#3140 .
The WGPU issue is linked in this comment, which I think is really visible to new users because adding the
Msaa
resource is one of the first settings new users learn, imo.I'm not 100% sure what is needed in Bevy to support them, beyond offering the option to set these values, but I've seen issues being opened around trying to the the samples count to something other than 1x and 4x, and Cart has said it's something Bevy should support.
What solution would you like?
Bevy should support setting the MSAA samples count to 2x and 8x as well. Ideally by adding them to the enum introduced in #7292 (if that gets merged, it seems the preferred solution based on this other comment by Cart).
What alternative(s) have you considered?
At the very least imo the linked comment should reference this internal issue instead of the WGPU one, until there's support for 2x and 8x samples in Bevy.
Additional context
Nothing else.
The text was updated successfully, but these errors were encountered: