Size in TextLayoutInfo does not correspond to actual Text2d dimensions with non-one scale factor

[rparrett]

Bevy version

main

Relevant system information

AdapterInfo { name: "Apple M1 Max", vendor: 0, device: 0, device_type: IntegratedGpu, driver: "", backend: Metal }
SystemInfo { os: "MacOS 13.1 ", kernel: "22.2.0", cpu: "Apple M1 Max", core_count: "10", memory: "64.0 GiB" }

(Scale factor 2.0)

What you did

Spawn a Text2dBundle with a SpriteBundle in the background, sized according to TextLayoutInfo.size.

use bevy::{prelude::*, text::TextLayoutInfo};

fn main() {
    App::new()
        .add_plugins(DefaultPlugins)
        .add_startup_system(setup)
        .add_system(resize)
        .run();
}

fn resize(
    mut sprite_query: Query<&mut Sprite>,
    info_query: Query<&TextLayoutInfo, Changed<TextLayoutInfo>>,
) {
    let mut sprite = sprite_query.single_mut();

    for info in &info_query {
        sprite.custom_size = Some(Vec2::splat(4.) + info.size);
    }
}

fn setup(mut commands: Commands, asset_server: Res<AssetServer>) {
    commands.spawn(Camera2dBundle::default());

    commands.spawn(Text2dBundle {
        text: Text::from_section(
            "text2dtext2dtext2d",
            TextStyle {
                font: asset_server.load("fonts/FiraSans-Bold.ttf"),
                font_size: 60.0,
                color: Color::WHITE,
            },
        ),
        transform: Transform::from_xyz(0., 0., 1.),
        ..default()
    });

    commands.spawn(SpriteBundle {
        sprite: Sprite {
            color: Color::BLACK,
            ..default()
        },
        ..default()
    });
}

What went wrong

I expected a black box underneath my text, with 4px of padding.

Instead, the black box is 2x the size of the text with an additional 4px of padding.

Additional information

I had previously used Text2dSize for this purpose which worked fine, but it was removed in #6807.

I can/will work around this by querying for the scale factor and dividing, but it seems like a hack.

[ickshonpe]

This is my fault, I should have considered this when I made this change.

I think this points to a place the code can be simplified and there isn't any need for TextInfo to be a scaled value. It's just inverted again in the extraction function anyway.

I'll make a short PR that should fix it now.

[ickshonpe]

#7794