Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gamepad viewer: drawn border for the stick zones #10102

Closed

Conversation

mockersf
Copy link
Member

Objective

Solution

  • Increase the extent size so that it's bigger than the live zone and draws a border
  • Also make it darker

@mockersf mockersf added C-Examples An addition or correction to our examples A-Input Player input via keyboard, mouse, gamepad, and more labels Oct 12, 2023
@rparrett
Copy link
Contributor

rparrett commented Oct 13, 2023

Nice catch.

I like the idea of a border, but the original intention wasn't to have a border, just to visualize the full extents vs. the edge of the livezone.

I think that maybe we could change the LIVE_COLOR so that it is not the same as the clear color and this would accomplish the same thing.

edit: with this change set, the end of the livezone and the border are the same color, so it it difficult to tell how it is configured.

@rparrett
Copy link
Contributor

rparrett commented Jan 7, 2024

My comment above is no longer accurate after the recent default clear color change. The edge of the live zone can now be distinguished from the gamepad bounds.

It's still my opinion that there's not actually a bug to fix here with regard to the lack of a "border."

The colors in the example could use some tweaking after that change though.

@mockersf mockersf closed this Jan 23, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jan 23, 2024
# Objective

Since #10339, the contrast in this example has been very low. While I
was in there, I made a few other tweaks to the style.

Alternative to #10102.

## Solution

- Increase brightness of inactive buttons for higher contrast on the new
clear color
- Combine `DEAD_COLOR` and `EXTENT_COLOR`. These were using the same
value, and combining them might make the intent a little clearer. (This
is the single color for "not the live zone.")
- Make the "stick buttons" slightly smaller, so it's a bit more obvious
that they are sitting inside of the default dead zone.
- Remove explicit text color -- it was the same as the default
- Add top-left margin to the text in the top left, and change the font
size to better match other examples with text in the corner.

## Screenshots

<details>
  <summary>With Bevy's default dead / live zones.</summary>
Before / After


![default](https://github.com/bevyengine/bevy/assets/200550/67bf1f5c-7fc9-4e74-87cf-2a94fcf59a50)
</details>

<details>
<summary>With Bevy's old dead / live zones. (with the upper live zone
boundary != 1.0)</summary>
Before / After


![old](https://github.com/bevyengine/bevy/assets/200550/3aab6a2a-ad57-4749-b2e5-51ed34072b2c)
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Input Player input via keyboard, mouse, gamepad, and more C-Examples An addition or correction to our examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants