Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default inherited visibility when parent has invalid components #10275

Merged
merged 3 commits into from
Oct 27, 2023
Merged

default inherited visibility when parent has invalid components #10275

merged 3 commits into from
Oct 27, 2023

Conversation

raffaeleragni
Copy link
Contributor

Situation

  • In case of parent without visibility components, the visibility inheritance of children creates a panic.

Solution

  • Apply same fallback visibility as parent not found instead of panic.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Hierarchy Parent-child entity hierarchies A-Rendering Drawing game state to the screen P-Crash A sudden unexpected crash labels Oct 26, 2023
alice-i-cecile
alice-i-cecile approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a sensible fallback, and we should really avoid internal panics wherever possible.

I think that this isn't even worth logging: it's a perfectly good interpretation of how the default should work and is consistent with the None branch above.

@james7132 james7132 added this pull request to the merge queue Oct 27, 2023
Merged via the queue into bevyengine:main with commit b22db47 Oct 27, 2023
21 checks passed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@raffaeleragni @ameknite
default inherited visibility when parent has invalid components (bevy…
f532d95 
…engine#10275)

# Situation

- In case of parent without visibility components, the visibility
inheritance of children creates a panic.

## Solution

- Apply same fallback visibility as parent not found instead of panic.
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@raffaeleragni
default inherited visibility when parent has invalid components (bevy…
bc59b68 
…engine#10275)

# Situation

- In case of parent without visibility components, the visibility
inheritance of children creates a panic.

## Solution

- Apply same fallback visibility as parent not found instead of panic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

@JoJoJet JoJoJet JoJoJet approved these changes

Assignees
No one assigned
Labels
A-Hierarchy Parent-child entity hierarchies A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-Crash A sudden unexpected crash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raffaeleragni @james7132 @alice-i-cecile @JoJoJet