Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an Entry api to EntityWorldMut. #10650

Merged
merged 20 commits into from
Nov 21, 2023
Merged

Add an Entry api to EntityWorldMut. #10650

merged 20 commits into from
Nov 21, 2023

Commits on Nov 19, 2023

  1. Added Entry, OccupiedEntry and VacantEntry

    @13ros27
    13ros27 committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    7dc910a View commit details
    Browse the repository at this point in the history

  2. Added Entry.add_modify which uses OccupiedEntry.get_mut, which does l… 

    …ifetime transmutation with questionable safety, question for the future
    @13ros27
    13ros27 committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    d5c0e23 View commit details
    Browse the repository at this point in the history

  3. Added Entry.or_default, using OccupiedEntry.into_mut and VacantEntry.… 

    …insert (more questionable transmutation)
    @13ros27
    13ros27 committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    17b924e View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Added Entry.insert_entry

    @13ros27
    13ros27 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    808e2b1 View commit details
    Browse the repository at this point in the history

  2. Added Entry.or_insert

    @13ros27
    13ros27 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    35804b0 View commit details
    Browse the repository at this point in the history

  3. Added Entry.or_insert_with

    @13ros27
    13ros27 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    568cfca View commit details
    Browse the repository at this point in the history

  4. Fixed Entry.insert_entry so that it will change the value if Occupi… 

    …ed (otherwise we should be using `or_insert`)
    @13ros27
    13ros27 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    a68f114 View commit details
    Browse the repository at this point in the history

  5. Fixed lifetimes and signatures to avoid the insane lifetime alchemy

    @13ros27
    13ros27 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    fa5ed2b View commit details
    Browse the repository at this point in the history

  6. Added OccupiedEntry.get and OccupiedEntry.take

    @13ros27
    13ros27 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    215ab4c View commit details
    Browse the repository at this point in the history

  7. Moved _marker to after entity_world

    @13ros27
    13ros27 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    1e27ce2 View commit details
    Browse the repository at this point in the history

  8. Added basic docs (no examples yet)

    @13ros27
    13ros27 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    d936215 View commit details
    Browse the repository at this point in the history

  9. Fixed some doc-links and made these types public so they show up in t… 

    …he documentation
    @13ros27
    13ros27 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    6636a52 View commit details
    Browse the repository at this point in the history

  10. Added examples to all of Entry's methods

    @13ros27
    13ros27 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    1ce81c2 View commit details
    Browse the repository at this point in the history

  11. Added examples to the methods of OccupiedEntry and VacantEntry

    @13ros27
    13ros27 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    b7ebc40 View commit details
    Browse the repository at this point in the history

  12. Appeased clippy

    @13ros27
    13ros27 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    2190952 View commit details
    Browse the repository at this point in the history

  13. Adjusted doc comment 'default' -> 'given default'

    @13ros27
    13ros27 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    71e0e81 View commit details
    Browse the repository at this point in the history

  14. Add doc test 

    Co-authored-by: Pascal Hertleif <[email protected]>
    @alice-i-cecile @killercup
    alice-i-cecile and killercup authored Nov 20, 2023
    Configuration menu
    Copy the full SHA
    d69e4fa View commit details
    Browse the repository at this point in the history

  15. Fixed doc-test

    @13ros27
    13ros27 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    0c989d8 View commit details
    Browse the repository at this point in the history

  16. Adjusted doc comment and added an extra comment to OccupiedEntry ex… 

    …plaining how it must be occupied before being created (it has private fields so this shouldn't be a problem for user code).
    @13ros27
    13ros27 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    55c688b View commit details
    Browse the repository at this point in the history

  17. Replaced unwrap_unchecked with unwrap and changed safety comments to … 

    …comments explaining why it should never panic.
    @13ros27
    13ros27 committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    0ec411c View commit details
    Browse the repository at this point in the history