Fix Asset Loading Bug #10698
Merged
Fix Asset Loading Bug #10698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused by improper comparison between `UntypedAssetId`'s
nicopap
added
C-Bug
nicopap
approved these changes
Nov 22, 2023
alice-i-cecile
approved these changes
Nov 22, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
@bushrat011899 does that also apply here? https://github.com/bevyengine/bevy/blob/main/crates/bevy_asset/src/id.rs#L356 I don't get which eq is called here but the eq from Asset doesn't check for typeid |
|
No, that line calls the |
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective - Fixes bevyengine#10695 ## Solution Fixed obvious blunder in `PartialEq` implementation for `UntypedAssetId`'s where the `TypeId` was not included in the comparison. This was not picked up in the unit tests I added because they only tested over a single asset type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Fixed obvious blunder in
PartialEqimplementation forUntypedAssetId's where theTypeIdwas not included in the comparison. This was not picked up in the unit tests I added because they only tested over a single asset type.