Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cubic splines overhaul #10701

Merged
merged 90 commits into from
Feb 28, 2024
Merged

Cubic splines overhaul #10701

merged 90 commits into from
Feb 28, 2024

Commits on Nov 22, 2023

  1. Added Nurbs spline

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    0152a0f View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Helper methods for generating various knot vectors

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    344c942 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2023

  1. Added IntoIterator and Extend implementations for CubicCurve

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    70a13c5 View commit details
    Browse the repository at this point in the history

  2. Added push_segment method

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    19e6772 View commit details
    Browse the repository at this point in the history

  3. Added linear spline

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    004a72c View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. Make Point trait impl a blanket impl

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    ae63196 View commit details
    Browse the repository at this point in the history

  2. Removed unused imports

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    22542c1 View commit details
    Browse the repository at this point in the history

  3. Moved some math to helper associated functions

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    7972a72 View commit details
    Browse the repository at this point in the history

  4. Fixed open uniform knot vector generation function

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    6084556 View commit details
    Browse the repository at this point in the history

  5. Implementation for basis matrix generation

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    d738eed View commit details
    Browse the repository at this point in the history

  6. Implemented cubci generator for nurbs

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    6246848 View commit details
    Browse the repository at this point in the history

  7. Weight normalization and application

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    dec3be5 View commit details
    Browse the repository at this point in the history

  8. Fixed lint error

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    95c8e08 View commit details
    Browse the repository at this point in the history

  9. Moved coefficients computation to CubicSegment

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    0101867 View commit details
    Browse the repository at this point in the history

  10. Fixed typo in comment

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    c1a5105 View commit details
    Browse the repository at this point in the history

  11. Extract multiplied index to a variable

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    1407647 View commit details
    Browse the repository at this point in the history

  12. Remoevd panics with Result and error enum

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    2e0a2a4 View commit details
    Browse the repository at this point in the history

  13. Improvbed wording in open uniform knot vector fn documentation

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    42de336 View commit details
    Browse the repository at this point in the history

  14. Removed code that wasn't doing anything

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    e3f45e5 View commit details
    Browse the repository at this point in the history

  15. Made weight normalization use L0 norm

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    754d3fe View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2023

  1. Correct misunderstanding of windows method

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    3c3f34b View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Improved documentation of CubicNurbs

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    2d3cc3b View commit details
    Browse the repository at this point in the history

  2. Added 4 point minimum note to nurbs constructor

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    4fc0fa8 View commit details
    Browse the repository at this point in the history

  3. Fixed an error in CubicBSpline::new doc comment

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    410dade View commit details
    Browse the repository at this point in the history

  4. Wording and typo fixes

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    eff9f98 View commit details
    Browse the repository at this point in the history

  5. Wording fix for CubicNurbs::new

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    26c0ea2 View commit details
    Browse the repository at this point in the history

  6. Import CubicNurbs and CubicNurbsError in prelude

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    d5c2da5 View commit details
    Browse the repository at this point in the history

  7. Fixed NURBS example

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    f5e8580 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Improved doc wording for normalize_weights

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    68d88fa View commit details
    Browse the repository at this point in the history

  2. Fixed typo

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    d9c0187 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Remove redundant interpolation information from nurbs doc

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    a1ba5e5 View commit details
    Browse the repository at this point in the history

  2. Simpler check for knot vector values

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    209091e View commit details
    Browse the repository at this point in the history

  3. REplace unwrap with expect

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    7996678 View commit details
    Browse the repository at this point in the history

  4. Use Self::knot_vector_expected_length

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    7dd0137 View commit details
    Browse the repository at this point in the history

  5. Fix typos

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    ecb5f8e View commit details
    Browse the repository at this point in the history

  6. Inline i to use constant knot vector indexes instead

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    c10298e View commit details
    Browse the repository at this point in the history

  7. Use sum instead of fold

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    77ba887 View commit details
    Browse the repository at this point in the history

  8. Consume weights vector for normalization instad of mutable borrow

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    5cb413e View commit details
    Browse the repository at this point in the history

  9. zip iterators of windows instead of using enumerate

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    6ebd6b7 View commit details
    Browse the repository at this point in the history

  10. Fix knot vector values check

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    b4030fd View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Update glam version

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    a8a8464 View commit details
    Browse the repository at this point in the history

  2. Use thiserror re-export from bevy_utils

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    5340921 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into cubic-splines-overhaul

    @JohnTheCoolingFan
    JohnTheCoolingFan authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    e5453ad View commit details
    Browse the repository at this point in the history

  4. Typo fix 

    Co-authored-by: IQuick 143 <[email protected]>
    @alice-i-cecile @IQuick143
    alice-i-cecile and IQuick143 authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    325816f View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. Typo fix 

    Co-authored-by: IQuick 143 <[email protected]>
    @JohnTheCoolingFan @IQuick143
    JohnTheCoolingFan and IQuick143 authored Jan 27, 2024
    Configuration menu
    Copy the full SHA
    3501ef4 View commit details
    Browse the repository at this point in the history

  2. Typo fix 

    Co-authored-by: IQuick 143 <[email protected]>
    @JohnTheCoolingFan @IQuick143
    JohnTheCoolingFan and IQuick143 authored Jan 27, 2024
    Configuration menu
    Copy the full SHA
    c07b2e4 View commit details
    Browse the repository at this point in the history

  3. Change knot vector index from expression to constant 

    Co-authored-by: IQuick 143 <[email protected]>
    @JohnTheCoolingFan @IQuick143
    JohnTheCoolingFan and IQuick143 authored Jan 27, 2024
    Configuration menu
    Copy the full SHA
    7be7e69 View commit details
    Browse the repository at this point in the history

  4. Document wefault weights and knot vector for nurbs

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    0bca0fd View commit details
    Browse the repository at this point in the history

  5. Remove multiplier argument in CubicSegment::coefficients

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    80afd61 View commit details
    Browse the repository at this point in the history

  6. Use assign and divide operator

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    6ad1d15 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. CubicNurbs documentation improvements

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    2b9063b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into cubic-splines-overhaul

    @JohnTheCoolingFan
    JohnTheCoolingFan authored Jan 28, 2024
    Configuration menu
    Copy the full SHA
    9e50087 View commit details
    Browse the repository at this point in the history

  3. Make BSpline matrix an expression 

    Assembly analysis shows that using an expression instead of applying the
div 6.0 operation using an iterator produces smaller and probably more
efficient code. The division by 6.0 was left in the matrix on all values
to explicitly show that all values are divided by it. Manually
simplifying some values doesn't result in any difference in the compiled code.
Godbolt: https://godbolt.org/z/MMfMhnMsq
    @JohnTheCoolingFan
    JohnTheCoolingFan committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    7239dd2 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Better wording for linear spline 

    Co-authored-by: Alice Cecile <[email protected]>
    @JohnTheCoolingFan @alice-i-cecile
    JohnTheCoolingFan and alice-i-cecile authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    579e70b View commit details
    Browse the repository at this point in the history

  2. Ducmentation for CubicSegment::coefficients

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    3410565 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Revert "Make BSpline matrix an expression" 

    This reverts commit 7239dd2.

The reason is that in actuality, the assembly produced is identical at
opt-level=3. Godbolt: https://godbolt.org/z/csqG1Y19P
    @JohnTheCoolingFan
    JohnTheCoolingFan committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    a4f5537 View commit details
    Browse the repository at this point in the history

  2. Implement RationalCurve and RationalSegment for NURBS.

    @IQuick143
    IQuick143 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    23de063 View commit details
    Browse the repository at this point in the history

  3. Change over polynomial evaluation scheme in CubicSegment

    @IQuick143
    IQuick143 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    93a0d3f View commit details
    Browse the repository at this point in the history

  4. Implement From<CubicCurve> for RationalCurve. 

    Add test.
    @IQuick143
    IQuick143 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    7a46d54 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Fix incorrect test labels. 

    Co-authored-by: JohnTheCoolingFan <[email protected]>
    @IQuick143 @JohnTheCoolingFan
    IQuick143 and JohnTheCoolingFan authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    ed1d974 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from IQuick143/cubic-splines-overhaul 

    Added Rational Curves
    @JohnTheCoolingFan
    JohnTheCoolingFan authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    c9a2f19 View commit details
    Browse the repository at this point in the history

  3. Formatting

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    adf9faf View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into cubic-splines-overhaul

    @JohnTheCoolingFan
    JohnTheCoolingFan authored Jan 31, 2024
    Configuration menu
    Copy the full SHA
    52697c4 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Improved spline documentation

    @NthTensor
    NthTensor committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    ecbc0c4 View commit details
    Browse the repository at this point in the history

  2. Fix nonlinearity and clean up language

    @NthTensor
    NthTensor committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    4a4c418 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Fix typoes and CI

    @NthTensor
    NthTensor committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    f38e62a View commit details
    Browse the repository at this point in the history

  2. Remove circular arc test case

    @NthTensor
    NthTensor committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    3c295fd View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. Re-add corrected circular arc test

    @NthTensor
    NthTensor committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    48fbb7d View commit details
    Browse the repository at this point in the history

  2. Fix code style

    @JohnTheCoolingFan
    JohnTheCoolingFan authored Feb 3, 2024
    Configuration menu
    Copy the full SHA
    db764b6 View commit details
    Browse the repository at this point in the history

  3. CI fix

    @JohnTheCoolingFan
    JohnTheCoolingFan authored Feb 3, 2024
    Configuration menu
    Copy the full SHA
    dda207e View commit details
    Browse the repository at this point in the history

  4. Fix type name in doc comment

    @JohnTheCoolingFan
    JohnTheCoolingFan authored Feb 3, 2024
    Configuration menu
    Copy the full SHA
    ae4bb38 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #2 from NthTensor/cubic-splines-overhaul 

    Finishing Touches
    @JohnTheCoolingFan
    JohnTheCoolingFan authored Feb 3, 2024
    Configuration menu
    Copy the full SHA
    1280053 View commit details
    Browse the repository at this point in the history

  6. Typo fixes 

    Co-authored-by: IQuick 143 <[email protected]>
    @JohnTheCoolingFan @IQuick143
    JohnTheCoolingFan and IQuick143 authored Feb 3, 2024
    Configuration menu
    Copy the full SHA
    8100a70 View commit details
    Browse the repository at this point in the history

  7. Divide by max - min instead of max

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    3b60751 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. Merge branch 'main' into cubic-splines-overhaul

    @JohnTheCoolingFan
    JohnTheCoolingFan authored Feb 4, 2024
    Configuration menu
    Copy the full SHA
    23bd37e View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. Revert "Use thiserror re-export from bevy_utils" 

    This reverts commit 5340921.
    @JohnTheCoolingFan
    JohnTheCoolingFan committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    b03fbb9 View commit details
    Browse the repository at this point in the history

  2. Revert "Make Point trait impl a blanket impl" 

    This reverts commit ae63196.
    @JohnTheCoolingFan
    JohnTheCoolingFan committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    d344566 View commit details
    Browse the repository at this point in the history

  3. Import Vec3 and Vec3A

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    2269a92 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'bevyengine:main' into cubic-splines-overhaul

    @JohnTheCoolingFan
    JohnTheCoolingFan authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    3126fd5 View commit details
    Browse the repository at this point in the history

  5. Revert "Import Vec3 and Vec3A" 

    This reverts commit 2269a92.
    @JohnTheCoolingFan
    JohnTheCoolingFan committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    5cc66be View commit details
    Browse the repository at this point in the history

  6. Reapply "Make Point trait impl a blanket impl" 

    This reverts commit d344566.
    @JohnTheCoolingFan
    JohnTheCoolingFan committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    5aea5cc View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into cubic-splines-overhaul

    @JohnTheCoolingFan
    JohnTheCoolingFan authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    7b6d54e View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Revert "Reapply "Make Point trait impl a blanket impl"" 

    This reverts commit 5aea5cc.
    @JohnTheCoolingFan
    JohnTheCoolingFan committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    1d09313 View commit details
    Browse the repository at this point in the history

  2. Import required types

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    039ba81 View commit details
    Browse the repository at this point in the history

  3. Implement Point for Vec4

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    70e67f1 View commit details
    Browse the repository at this point in the history

  4. Relax dependencies of Point trait

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    983749a View commit details
    Browse the repository at this point in the history

  5. Implement Point for Quat

    @JohnTheCoolingFan
    JohnTheCoolingFan committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c22e971 View commit details
    Browse the repository at this point in the history

  6. Fix typo

    @alice-i-cecile
    alice-i-cecile authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    4b4322e View commit details
    Browse the repository at this point in the history

  7. Fix typos

    @alice-i-cecile
    alice-i-cecile authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    f6d8d1b View commit details
    Browse the repository at this point in the history

  8. Typos and wording fixes 

    Co-authored-by: Joona Aalto <[email protected]>
    @JohnTheCoolingFan @Jondolf
    JohnTheCoolingFan and Jondolf authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    32c35fc View commit details
    Browse the repository at this point in the history