reflect: maximally relax TypePath bounds
#11037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGVSV
approved these changes
Dec 20, 2023
ItsDoot
added
C-Code-Quality
ItsDoot
approved these changes
Dec 20, 2023
ItsDoot
added
C-Usability
MrGVSV
added
the
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
TypePathimplementations to universally ignore the types of fields, rather than use the same bounds as other implementations. I think this is a more holistic solution than Fix nested generics in Reflect derive #10791 because it totally erases the finicky bounds we currently generate, helping to untangle the reflection trait system.