Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add double end arrow to gizmos #11890

Merged
merged 18 commits into from
Apr 16, 2024
Merged

Add double end arrow to gizmos #11890

merged 18 commits into from
Apr 16, 2024

Conversation

pablo-lua
Copy link
Contributor

@pablo-lua pablo-lua commented Feb 16, 2024 •
edited
Loading

Objective

Solution

  • Creation of new field and method to the ArrowBuilder

Changelog

Added

  • New field ArrowBuilder::double_ended
  • New method ArrowBuilder::with_double_end to redefine the double_ended field

Additional

I added this in the 3d_gizmos example, that's the result:

image

I added this arrow in the 2d_gizmos example too:

image

afonsolage
afonsolage suggested changes Feb 16, 2024
View reviewed changes
crates/bevy_gizmos/src/arrows.rs Outdated Show resolved Hide resolved
afonsolage
afonsolage suggested changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@afonsolage afonsolage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems fine, only small changes and I think the 3d example doesn't showcase well the double ended gizmos.

@Kanabenki Kanabenki added C-Feature A new feature, making something new possible A-Gizmos Visual editor and debug gizmos labels Feb 16, 2024
@pablo-lua
Copy link
Contributor Author

I changed the arrow position in the example, it is like the image now.

@nicopap nicopap mentioned this pull request Feb 20, 2024
Open
57 tasks
@pablo-lua pablo-lua added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 9, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 16, 2024
Merged via the queue into bevyengine:main with commit 6b0e3fa Apr 16, 2024
28 checks passed
@pablo-lua pablo-lua deleted the double-end-arrow branch April 16, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lynn-lumen lynn-lumen lynn-lumen approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@afonsolage afonsolage afonsolage approved these changes

Assignees
No one assigned
Labels
A-Gizmos Visual editor and debug gizmos C-Feature A new feature, making something new possible S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablo-lua @afonsolage @alice-i-cecile @lynn-lumen @Kanabenki