revert PointLightBundle to DirectionalLightBundle change made to asset_loading example between 0.12.1 and 0.13.0 #11935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_loading example between 0.12.1 and 0.13.0
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
|
Complete diff of this example between diff --git a/examples/asset/asset_loading.rs b/examples/asset/asset_loading.rs
index 6a931dc62..24b912597 100644
--- a/examples/asset/asset_loading.rs
+++ b/examples/asset/asset_loading.rs
@@ -79,8 +79,8 @@ fn setup(
..default()
});
// light
- commands.spawn(PointLightBundle {
- transform: Transform::from_xyz(4.0, 5.0, 4.0),
+ commands.spawn(DirectionalLightBundle {
+ transform: Transform::from_xyz(4.0, 5.0, 4.0).looking_at(Vec3::ZERO, Vec3::Y),
..default()
});
// cameraRendered example as of 
Rendered example as of 
Rendered example with the changes in this PR (revert to 
|
alice-i-cecile
approved these changes
Feb 18, 2024
alice-i-cecile
added
A-Rendering
james7132
approved these changes
Feb 18, 2024
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
…t_loading example between 0.12.1 and 0.13.0 (bevyengine#11935) # Objective - revert a single-line change made to `examples/asset/asset_loading` example between `v0.12.1` release and `v0.13.0` release which resulted in a too-bright, washed-out rendering ## Solution - reverted the changes made to this example between `v0.12.1` and `v0.13.0`
msvbg
pushed a commit
to msvbg/bevy
that referenced
this pull request
Feb 26, 2024
…t_loading example between 0.12.1 and 0.13.0 (bevyengine#11935) # Objective - revert a single-line change made to `examples/asset/asset_loading` example between `v0.12.1` release and `v0.13.0` release which resulted in a too-bright, washed-out rendering ## Solution - reverted the changes made to this example between `v0.12.1` and `v0.13.0`
mockersf
pushed a commit
that referenced
this pull request
Feb 27, 2024
…t_loading example between 0.12.1 and 0.13.0 (#11935) # Objective - revert a single-line change made to `examples/asset/asset_loading` example between `v0.12.1` release and `v0.13.0` release which resulted in a too-bright, washed-out rendering ## Solution - reverted the changes made to this example between `v0.12.1` and `v0.13.0`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
examples/asset/asset_loadingexample betweenv0.12.1release andv0.13.0release which resulted in a too-bright, washed-out renderingSolution
v0.12.1andv0.13.0